[Bug]: Can't move folders across different external storage volumes

[rbeier]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Hi,

I found a bug related to external storage. I'm using Nextcloud in a docker container on my NAS and have different volumes mounted as external (local) storage.

When moving a folder from one mounting point (Share) to another (Daten) the following errors occurs:

[PHP] Fehler: rename(//mnt/Share/Downloads/Fotos,//mnt/Daten/Fotos): Invalid cross-device link at /var/www/html/lib/private/Files/Storage/Local.php#377

MOVE /remote.php/dav/files/admin/Share/Downloads/Fotos
from 192.168.0.22 by admin at 2023-04-14T15:33:57+00:00

[PHP] Fehler: rename(): The first argument to copy() function cannot be a directory at /var/www/html/lib/private/Files/Storage/Local.php#377

MOVE /remote.php/dav/files/admin/Share/Downloads/Fotos
from 192.168.0.22 by admin at 2023-04-14T15:33:57+00:00

Did some research, turns out this is a known php bug which can be bypassed by using

exec("mv ".escapeshellarg($strOldPath)." ".escapeshellarg($strNewPath));

see https://bugs.php.net/bug.php?id=54097 for more information.

btw. copying the folder works fine.

Steps to reproduce

1. mount different external storages in your nextcloud instance
2. move a folder from one external storage to another

Expected behavior

The folder should be moved to the volume

Installation method

Community Docker image

Nextcloud Server version

24

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "26.0.0.11",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "defaultapp": "files"
    }
}

List of activated Apps

Enabled:
  - activity: 2.18.0
  - cloud_federation_api: 1.9.0
  - contactsinteraction: 1.7.0
  - dav: 1.25.0
  - federatedfilesharing: 1.16.0
  - federation: 1.16.0
  - files: 1.21.1
  - files_external: 1.18.0
  - files_pdfviewer: 2.7.0
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - files_versions: 1.19.1
  - firstrunwizard: 2.15.0
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - nextcloud_announcements: 1.15.0
  - notifications: 2.14.0
  - oauth2: 1.14.0
  - password_policy: 1.16.0
  - privacy: 1.10.0
  - provisioning_api: 1.16.0
  - recommendations: 1.5.0
  - related_resources: 1.1.0-alpha1
  - serverinfo: 1.16.0
  - settings: 1.8.0
  - sharebymail: 1.16.0
  - support: 1.9.0
  - survey_client: 1.14.0
  - systemtags: 1.16.0
  - text: 3.7.2
  - theming: 2.1.1
  - twofactor_backupcodes: 1.15.0
  - updatenotification: 1.16.0
  - viewer: 1.10.0
  - workflowengine: 2.8.0
Disabled:
  - admin_audit: 1.16.0
  - bruteforcesettings: 2.6.0
  - circles: 26.0.0 (installed 26.0.0)
  - comments: 1.16.0 (installed 1.16.0)
  - dashboard: 7.6.0 (installed 7.6.0)
  - encryption: 2.14.0
  - photos: 2.2.0 (installed 2.2.0)
  - suspicious_login: 4.4.0
  - twofactor_totp: 8.0.0-alpha.0
  - user_ldap: 1.16.0
  - user_status: 1.6.0 (installed 1.6.0)
  - weather_status: 1.6.0 (installed 1.6.0)

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[szaimen]

Hi, please update to 25.0.7 or better 26.0.2 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 26-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

[rbeier]

Hi,
updated to 26.0.2 but the bug still occurs. Got a 403 response from
MOVE http://192.168.0.2:8003/remote.php/dav/files/admin/Share/Downloads/xyz

Response:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\Forbidden</s:exception>
  <s:message/>
</d:error>

Got the following errors in the log:

[PHP] Fehler: rename(//mnt/Share/Downloads/xyz,//mnt/Games/xyz): Success at /var/www/html/lib/private/Files/Storage/Local.php#378

MOVE /remote.php/dav/files/admin/Share/Downloads/xyz
from 192.168.0.22 by admin at 2023-06-02T13:25:55+00:00

[PHP] Fehler: rename(): The first argument to copy() function cannot be a directory at /var/www/html/lib/private/Files/Storage/Local.php#378

MOVE /remote.php/dav/files/admin/Share/Downloads/xyz
from 192.168.0.22 by admin at 2023-06-02T13:25:55+00:00

[joshtrichards]

Duplicate of #14743

[bgottschall]

Version 27.0.2 bug still present

[joshtrichards]

@bgottschall - The fix is in #38623 so it'll show up in v28.