Skip to content

Adjust badges#1977

Merged
nickvergessen merged 1 commit into
masterfrom
adjust-badges
Nov 2, 2016
Merged

Adjust badges#1977
nickvergessen merged 1 commit into
masterfrom
adjust-badges

Conversation

@LukasReschke

Copy link
Copy Markdown
Member
  • Removes the Drone badge
    • This one is lying most of the time since it isn't checking master but the latest build. Thus it fails when it effectively doesn't fail. Let's remove that since it makes us look bad.
  • Add CodeCov badge
  • Add CII badge

cc @rullzer @MorrisJobke @jospoortvliet


Signed-off-by: Lukas Reschke lukas@statuscode.ch

- Removes the Drone badge
  - This one is lying most of the time since it isn't checking master but the latest build. Thus it fails when it effectively doesn't fail. Let's remove that since it makes us look bad.
- Add CodeCov badge
- Add CII badge

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Nov 2, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Nov 2, 2016
@mention-bot

Copy link
Copy Markdown

@LukasReschke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @MariusBluem and @schiessle to be potential reviewers.

@rullzer

rullzer commented Nov 2, 2016

Copy link
Copy Markdown
Member

👍

@nickvergessen

Copy link
Copy Markdown
Member

😢 👍

@nickvergessen nickvergessen merged commit dada3ff into master Nov 2, 2016
@nickvergessen nickvergessen deleted the adjust-badges branch November 2, 2016 11:35
@MorrisJobke

Copy link
Copy Markdown
Member

This one is lying most of the time since it isn't checking master but the latest build. Thus it fails when it effectively doesn't fail. Let's remove that since it makes us look bad.

Wrong - we build master and it showed the correct one - but mostly it was in the "Running" state because the next merge came in ;)

@ypid

ypid commented Nov 4, 2016

Copy link
Copy Markdown

Awesome work! CII Best Practices Nice 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants