Bump aws/aws-sdk-php to 3.240 - #34943
Closed
come-nc wants to merge 1 commit into
Closed
Conversation
come-nc
requested review from
a team,
ArtificialOwl,
PVince81,
juliusknorr and
kesselb
and removed request for
a team
November 3, 2022 14:22
PVince81
approved these changes
Nov 3, 2022
PVince81
left a comment
Member
There was a problem hiding this comment.
👍 after rebase/adjusting commit id
come-nc
marked this pull request as ready for review
November 3, 2022 16:02
Contributor
Author
Done, waiting on CI. |
come-nc
force-pushed
the
fix/bump-aws/aws-sdk-php-to-3.240
branch
from
November 3, 2022 16:06
5c2fb21 to
c0963be
Compare
Contributor
Author
Done, waiting on CI. |
come-nc
enabled auto-merge
November 3, 2022 16:55
Contributor
|
Not sure but seems like autoloaders are not up-to-date? |
Contributor
Author
|
/rebase |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud-command
force-pushed
the
fix/bump-aws/aws-sdk-php-to-3.240
branch
from
November 7, 2022 08:26
c0963be to
e7a899f
Compare
Contributor
Author
|
autoloaders are good but this look like real trouble: |
Contributor
|
@come-nc should we revert nextcloud/3rdparty#1210? |
Contributor
Author
No, it was merged with #34996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #34787 (comment)
Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com