feat: OCS Calendar Import - #55178
Conversation
12ad7af to
6838bbe
Compare
e000a47 to
a3431ef
Compare
provokateurin
left a comment
There was a problem hiding this comment.
The code comments in the controller are a bit useless, you might want to remove them to avoid confusion if the code is refactored later.
a3431ef to
3e048d5
Compare
2ac397f to
20a731c
Compare
20a731c to
0ad93ad
Compare
0ad93ad to
56838c2
Compare
45970d0 to
0ea9465
Compare
6631397 to
d0e8053
Compare
d0e8053 to
4d7c277
Compare
4d7c277 to
085f3d4
Compare
|
|
||
| use JsonSerializable; | ||
|
|
||
| interface ImportEvent extends JsonSerializable { |
There was a problem hiding this comment.
This was already discussed to be removed in back ports
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCP\AppFramework\Http; |
There was a problem hiding this comment.
new public API. this is going to be messy in the backport.
There was a problem hiding this comment.
Move the class into the private namespace, as discussed
There was a problem hiding this comment.
That discussion was for the back ports not the master
eb471ec to
e31ae56
Compare
DerDreschner
left a comment
There was a problem hiding this comment.
🐘 But tested it a month ago and was working there beside some issues that might be on my side, so 😄
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
e31ae56 to
06ea390
Compare
|
/backport to stable34 |
| public function callback(IOutput $output): void { | ||
|
|
||
| foreach ($this->generator as $chunk) { | ||
| print($chunk); |
There was a problem hiding this comment.
Why is it printing to stdout and not in the passed IOutput instance?
There was a problem hiding this comment.
Because no one flagged this as an issue...
I also just realized that this class now needs to be removed... because someone added the exact same functionality in
This is what happens when PR sit around for a year 🤦
Summary
Extracted from #49995
This adds the ability to export and import calendars via the OCS
OCS Import
Endpoint: /ocs/v2.php/calendar/import
Request: POST
Checklist