fix(DirectEditing): expose already used methods on the public interface - #55993
Merged
Conversation
juliusknorr
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
October 24, 2025 19:30
juliusknorr
force-pushed
the
fix/direct-editing-interface
branch
from
October 24, 2025 20:09
8951c3c to
027d1ca
Compare
Altahrim
approved these changes
Oct 27, 2025
joshtrichards
force-pushed
the
fix/direct-editing-interface
branch
from
June 17, 2026 19:37
027d1ca to
2b1b96b
Compare
joshtrichards
approved these changes
Jun 17, 2026
joshtrichards
enabled auto-merge
June 17, 2026 19:52
Signed-off-by: Julius Knorr <jus@bitgrid.net>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
AndyScherzinger
force-pushed
the
fix/direct-editing-interface
branch
from
June 18, 2026 16:15
fbbc730 to
abef770
Compare
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods had been on the implementation and are used in text for a long time already. They should be exposed on the public interface so we can cleanup the psalm baseline: