Skip to content

test(files): migrate files selection e2e from Cypress to Playwright - #61221

Merged
AndyScherzinger merged 2 commits into
masterfrom
test/migrate-files-selection-playwright
Jun 21, 2026
Merged

test(files): migrate files selection e2e from Cypress to Playwright#61221
AndyScherzinger merged 2 commits into
masterfrom
test/migrate-files-selection-playwright

Conversation

@pringelmann

@pringelmann pringelmann commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Migrates files/files-selection.cy.ts to Playwright.

Two intentional changes from the Cypress original:

  • The "select some files randomly" test now selects a fixed subset. The randomness added flake, not coverage.
  • Selection-count assertions use getByText('N selected') instead of the .files-list__selected CSS class.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes (test-only, N/A)
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version

AI

  • The content of this PR was partly or fully generated using AI

@pringelmann
pringelmann force-pushed the test/migrate-files-selection-playwright branch from 3c7487a to a15fc98 Compare June 11, 2026 21:24
@pringelmann pringelmann self-assigned this Jun 12, 2026
@pringelmann pringelmann added tests Related to tests CI labels Jun 12, 2026
@pringelmann pringelmann added this to the Nextcloud 35 milestone Jun 12, 2026
@pringelmann
test(files): migrate files selection e2e from Cypress to Playwright
09c94c5 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the test/migrate-files-selection-playwright branch from a15fc98 to 09c94c5 Compare June 17, 2026 08:03
@pringelmann pringelmann added the 3. to review Waiting for reviews label Jun 17, 2026
@pringelmann
pringelmann marked this pull request as ready for review June 17, 2026 08:31
@pringelmann
pringelmann requested a review from a team as a code owner June 17, 2026 08:31
@pringelmann
pringelmann requested review from CarlSchwan, artonge, nfebe, sorbaugh and susnux and removed request for a team June 17, 2026 08:31
susnux
susnux approved these changes Jun 18, 2026
View reviewed changes

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick only

Comment thread tests/playwright/support/sections/FilesListPage.ts Outdated
@pringelmann @susnux
fix: use accessible state checkbox selector instead of CSS
577f8a2 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Peter R. <peter.ringelmann@nextcloud.com>
@AndyScherzinger
AndyScherzinger merged commit 72025c0 into master Jun 21, 2026
197 of 199 checks passed
@AndyScherzinger
AndyScherzinger deleted the test/migrate-files-selection-playwright branch June 21, 2026 17:27
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@artonge artonge artonge approved these changes
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@pringelmann pringelmann

Labels

3. to review Waiting for reviews CI tests Related to tests

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

4 participants

@pringelmann @susnux @artonge @AndyScherzinger