fix(core): scope public share theme filter to the download icon#61648
Conversation
8f7cfb6 to
c7e6895
Compare
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
|
I stopped the backports of the first PR to prevent a regression. So the backports here will not be so clean. Not sure how best to proceed. I'm happy to unblock the other backports if that helps. |
c7e6895 to
b68dd67
Compare
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
b68dd67 to
c9aa644
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/61648/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c9aa644b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61648/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/61648/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c9aa644b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61648/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/61648/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c9aa644b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61648/stable34Error: Failed to check for changes with origin/stable34: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@max-nextcloud thanks for flagging. I'm not sure its worth it to backport this all the way to If we do want to backport the fix I can squash both changes into one commit and apply those to each stable. |
|
I agree with you, IMHO we do not need this on 32 - lets close the original backport there. But it was requested to be fixed at least for 34, maybe code did not change that much for 33? |
|
Sure will do :) |
Summary
#59175 added a global + class selector to scope the download-icon color filter to the explicit light/dark theme. Vue's scoped-style compiler drops everything after
:global(...). Sincedata-themesis set on<body>, the filter inverted the entire public share page whenever a theme was enforced. Moving the descendant inside the parens keeps the full selector and limits the filter to the icon.Before:
After:
Checklist
3. to review, feature component)stable32)