fix(setup): de-duplicate host parsing allowing IPv6 connections - #62932
Merged
Conversation
The de-duplicates the connection params parsing, previously it used `explode` to get host + port but this fails for IPv6 like `[::1]:80`. But a proper parsing is already available in the `ConnectionFactory`, so adjusted the code to reuse that. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
marked this pull request as ready for review
August 5, 2026 10:54
susnux
requested review from
Altahrim,
CarlSchwan,
come-nc,
provokateurin and
salmart-dev
and removed request for
a team and
provokateurin
August 5, 2026 10:54
CarlSchwan
approved these changes
Aug 5, 2026
7 tasks
come-nc
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The de-duplicates the connection params parsing,
previously it used
explodeto get host + port but this fails for IPv6 like[::1]:80. But a proper parsing is already available in theConnectionFactory, so adjusted the code to reuse that.Checklist
3. to review, feature component)stable32)AI (if applicable)