fix: allow file request upload when part_file_in_storage=false - #62986
Merged
Conversation
salmart-dev
requested review from
Altahrim,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
August 6, 2026 16:54
The part_file_in_storage option being disabled, causes files to be uploaded in the user's root, rather than in the final directory. This, in combination with the use of upload nicknames, was not detected by the patched check, causing uploads to check for the UPDATE permissions, which is not granted for file requests, making all uploads always fail. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/nickname-upload-from-root
branch
from
August 10, 2026 08:37
8aed8e4 to
54b796f
Compare
come-nc
approved these changes
Aug 13, 2026
susnux
approved these changes
Aug 18, 2026
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/62986/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 54b796fb
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/62986/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting the config value
part_file_in_storage=falseand trying to upload files in a file request, using local storage and providing a nickname always fail. The reason is that the storage wrapper fails to detect the case when the file gets uploaded in the root due to the configuration, failing the parent directory check and checking for the UPDATE permission instead of the CREATE one.Note: the fix aims at restoring working upload requests. The already-existing problem that despite the configuration, uploads may not happen in the user's root is a separate issue.
Reproducing the issue
part_file_in_storage=falseExpected result
The file is uploaded
Actual result
The upload fails
Checklist
3. to review, feature component)stable32)AI (if applicable)