Skip to content

Add DBAL Schema wrapper in OCP - #63013

Merged
CarlSchwan merged 5 commits into
masterfrom
carl/dbal-wrapper
Aug 10, 2026
Merged

Add DBAL Schema wrapper in OCP#63013
CarlSchwan merged 5 commits into
masterfrom
carl/dbal-wrapper

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Same as the DBAL one aside that Column::getType returns a string instead of a DBAL Type. Column::setType support both a DBAL Type and a string.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan added this to the Nextcloud 35 milestone Aug 7, 2026
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 7, 2026
@CarlSchwan CarlSchwan self-assigned this Aug 7, 2026
@CarlSchwan
CarlSchwan marked this pull request as ready for review August 7, 2026 10:14
@CarlSchwan
CarlSchwan requested review from leftybournes, nfebe, provokateurin and salmart-dev and removed request for a team August 7, 2026 10:14
come-nc
come-nc reviewed Aug 7, 2026
View reviewed changes

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing return type of getTable is breaking API, no?

Comment thread apps/federatedfilesharing/lib/Migration/Version1011Date20201120125158.php Outdated
@CarlSchwan

CarlSchwan commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

Changing return type of getTable is breaking API, no?

It's a consumable API so it should be fine as long as the returned object behaves the same as before

ChristophWurst
ChristophWurst reviewed Aug 7, 2026
View reviewed changes

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public API looks sane 👍

We could improve the strictness but that will break existing code

Comment thread lib/public/DB/Schema/IColumn.php Outdated
Comment thread lib/public/DB/Schema/IColumn.php Outdated
Comment thread lib/public/DB/Schema/IIndex.php Outdated
Comment thread lib/public/DB/Schema/IIndex.php Outdated
Comment thread lib/public/DB/Schema/ITable.php
come-nc
come-nc reviewed Aug 10, 2026
View reviewed changes
Comment thread lib/public/DB/Schema/IType.php
@CarlSchwan
feat(api): Add public OCP api for DB schema management
a2b8ec1 
Same as the DBAL one aside that Column::getType returns a string instead
of a DBAL Type. Column::setType support both a DBAL Type and a string.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
fix(db): Adapt migrations to new OCP\DB\Schema
9dad62c 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
fix: Mark interfaces as Consumable
37b79cc 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
feat: Remove IColumn::getOptions
8163913 
Prefer the fully typed methods instead and there is always the __call
magic method as fallback for apps.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
refactor(schema): Reduce the API surface
95b69fd 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
CarlSchwan enabled auto-merge August 10, 2026 14:32
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 10, 2026
@CarlSchwan
CarlSchwan merged commit 90d06ca into master Aug 10, 2026
227 of 229 checks passed
@CarlSchwan
CarlSchwan deleted the carl/dbal-wrapper branch August 10, 2026 17:28
@ChristophWurst ChristophWurst mentioned this pull request Aug 11, 2026
Merged
1 task
@susnux

susnux commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

I think adding this to documentation would be very good

@susnux susnux added the pending documentation This pull request needs an associated documentation update label Aug 11, 2026
@CarlSchwan

CarlSchwan commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

I have some local draft for the doc, I will submit it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes
@susnux susnux susnux approved these changes
@come-nc come-nc come-nc approved these changes
@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner
@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner
@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

4. to release Ready to be released and/or waiting for tests to finish pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlSchwan @susnux @ChristophWurst @come-nc