feat: Add Link pagination when possible - #63323
Open
CarlSchwan wants to merge 6 commits into
Open
Conversation
CarlSchwan
requested review from
Altahrim,
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
August 17, 2026 19:13
CarlSchwan
force-pushed
the
carl/pagination
branch
from
August 17, 2026 19:13
53a43a3 to
f35acb3
Compare
CarlSchwan
force-pushed
the
carl/pagination
branch
2 times, most recently
from
August 17, 2026 22:23
20c89f9 to
7224dae
Compare
come-nc
reviewed
Aug 18, 2026
Merged
Contributor
|
so this only supports for numeric offset+limit pagination, right? |
Merged
This use a private trait to have a consistent behavior Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
…thods Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Unfortunately static has return type didn't fix it but it is still more correct. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/pagination
branch
2 times, most recently
from
August 20, 2026 14:50
f405f94 to
f262d34
Compare
Member
Author
Done, but we don't really use cursor based pagination a lot in server or at all :( I added that to user_status and also added an API to the new ORM stuff to make it easier #63441 |
CarlSchwan
force-pushed
the
carl/pagination
branch
3 times, most recently
from
August 20, 2026 15:01
024bb44 to
311b811
Compare
CarlSchwan
force-pushed
the
carl/pagination
branch
from
August 20, 2026 15:46
311b811 to
5d5d085
Compare
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/pagination
branch
from
August 20, 2026 15:58
5d5d085 to
6bbbd7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This use a private trait to have a consistent behavior
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)