Fix one core migration: Only add taskprocessing columns if they don't exist - #63350
Merged
Merged
Conversation
…n adding columns in taskprocessing_tasks Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
requested review from
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
August 18, 2026 08:27
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable34 |
Merged
come-nc
approved these changes
Aug 18, 2026
joshtrichards
approved these changes
Aug 19, 2026
joshtrichards
left a comment
Member
There was a problem hiding this comment.
We should maybe do audit for these in all existing migrations -- this has come up several times before IIRC...
This was referenced Aug 19, 2026
Merged
Merged
Merged
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make OC\Core\Migrations\Version30000Date20240717111406 safer when adding columns in taskprocessing_tasks.
This migration step could not be executed more than once because it always tried to add 2 columns, whether they exist or not.
Checklist
3. to review, feature component)stable32)AI (if applicable)