Skip to content

fix: scope group share child permission updates to usergroup - #64187

Merged
susnux merged 1 commit into
masterfrom
fix/share-group-update-link-permissions
Sep 16, 2026
Merged

susnux merged 1 commit into
masterfrom
fix/share-group-update-link-permissions

Conversation

@kristian-zendato

@kristian-zendato kristian-zendato commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Restrict the group-share child update in DefaultShareProvider::update() so only TYPE_USERGROUP rows get new permissions/attributes. Public links that reuse parent for display are no longer escalated when the group share is edited.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kristian-zendato
kristian-zendato requested a review from a team as a code owner September 10, 2026 13:50
@kristian-zendato
kristian-zendato requested review from Altahrim, CarlSchwan, leftybournes and salmart-dev and removed request for a team September 10, 2026 13:50
@kristian-zendato kristian-zendato added 3. to review Waiting for reviews bug labels Sep 10, 2026
@solracsf solracsf added this to the Nextcloud 36 milestone Sep 12, 2026
@susnux
susnux force-pushed the fix/share-group-update-link-permissions branch from c43b8c0 to 5afa39f Compare September 15, 2026 10:36
@susnux

susnux commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@kristian-zendato can you please check this CI error? It seems to be related to your changes:

build/integration/sharing_features/sharing-v1-part3.feature:581 (on line 606)

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato force-pushed the fix/share-group-update-link-permissions branch from 5afa39f to a5faff3 Compare September 16, 2026 10:09
@susnux
susnux merged commit 21c29b1 into master Sep 16, 2026
183 of 185 checks passed
@susnux
susnux deleted the fix/share-group-update-link-permissions branch September 16, 2026 12:02
@susnux

susnux commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@susnux

susnux commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/backport to stable33

@susnux

susnux commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

/backport to stable34

@susnux

susnux commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

/backport to stable32

@susnux

susnux commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

/backport to stable31

@susnux

susnux commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

/backport to stable30

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants