Skip to content

fix: show custom permissions when share is removed from edit bundle - #64202

Merged
susnux merged 1 commit into
masterfrom
fix/file-sharing-custom-permission-label
Sep 15, 2026
Merged

susnux merged 1 commit into
masterfrom
fix/file-sharing-custom-permission-label

Conversation

@kristian-zendato

Copy link
Copy Markdown
Contributor

Summary

  • Fix permission bundle matching so it compares the full permissions bitmask against the configured edit bundle.
  • After refresh, shares with edit rights but without resharing now show Custom permissions instead of Can edit

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
@kristian-zendato
kristian-zendato requested a review from a team as a code owner September 10, 2026 18:44
@kristian-zendato
kristian-zendato requested review from skjnldsv, sorbaugh and susnux and removed request for a team September 10, 2026 18:44
@kristian-zendato kristian-zendato added bug 3. to review Waiting for reviews labels Sep 11, 2026
@solracsf solracsf added this to the Nextcloud 36 milestone Sep 12, 2026

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense 👍

@susnux
susnux merged commit c0182cb into master Sep 15, 2026
102 of 105 checks passed
@susnux
susnux deleted the fix/file-sharing-custom-permission-label branch September 15, 2026 17:13
@susnux

susnux commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@susnux

susnux commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/backport to stable34

@susnux

susnux commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

/backport to stable33

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants