fix: logs can leak sensitive information..

[akhil1508]

• Resolves: # [Bug]: Certain kinds of log lines can output sensitive information in the logs #64339

Summary

• After the commit 121973d336e, certain types of logger calls are outputting sensitive data like credentials in the error logs

  • for e.g.

    server/apps/dav/lib/Connector/Sabre/Auth.php

    Line 121 in f740a01

    Server::get(LoggerInterface::class)->error($e->getMessage(), ['exception' => $e]);

• This PR addresses this security issue

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[icewind1991]

Cannot reproduce the original issue, but the change is good either way.

Currently this info is duplicated in the logs

[icewind1991]

/backport to stable35

[icewind1991]

/backport to stable34

[icewind1991]

/backport to stable33

[susnux]

@icewind1991 maybe this is not about basic auth but about apache auth like http://user:pass@cloud in this case this might be a problem.

But agree this really makes sense anyways!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)