Skip to content

fix(dav): include duration in recurring event range - #64393

Closed
abhinavohri wants to merge 1 commit into
nextcloud:masterfrom
abhinavohri:fix/dav-recurring-event-last-occurrence
Closed

abhinavohri wants to merge 1 commit into
nextcloud:masterfrom
abhinavohri:fix/dav-recurring-event-last-occurrence

Conversation

@abhinavohri

@abhinavohri abhinavohri commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a bug where recurring events used the final occurrence's start time as lastoccurence instead of its end time. This caused appointment searches overlapping the final occurrence to skip the event and incorrectly expose the time slot as available.

The change calculates the duration of an occurrence before processing RDATE and RRULE, then adds that duration to the final occurrence's start time for finite recurrences.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Include the final occurrence duration when deriving the searchable time range for recurring calendar objects.

Assisted-by: Codex:gpt-5
Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
@susnux
susnux requested a review from hamza221 September 15, 2026 21:14
@susnux susnux added 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals bug labels Sep 15, 2026
@susnux susnux added this to the Nextcloud 36 milestone Sep 15, 2026
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

already addressed in #64315

Closing as duplicate

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Appointment schedules overplanning meeting proposals

3 participants