Link picker by juliusknorr · Pull Request #3700 · nextcloud/text

juliusknorr · 2023-01-26T07:53:50Z

Signed-off-by: Julius Härtl jus@bitgrid.net

📝 Summary

Refactor existing suggestion extensions to make code reusable
Implement a link picker plugiun
- Prepare extension
- Fetch link provider list from the backend
- Trigger link picker on provider
- Make sure that result gets inserted
- Adapt mention cypress tests to new component layout

Depends on

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

cypress · 2023-01-26T08:00:30Z

Passing run #8377 ↗︎

0	116	0	0	0

Details:

Link picker
Project: Text	Commit: `82036c3145`
Status: Passed	Duration: 03:59 💡
Started: Jan 30, 2023 4:35 PM	Ended: Jan 30, 2023 4:39 PM

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

julien-nc · 2023-01-26T14:14:02Z

Awesome!

I pushed a commit adding the glue to use the link picker in your suggestion plugin.

Text needs to be linked with @nextcloud/vue-richtext 's "enh/noid/reference-picker" branch.

Remaining issues:

Suggestions (provider list) still visible when the link picker modal is displayed
If we insert the link with a trailing space, rendering is not triggered. I guess we could insert a link node instead of the raw text (problem: we might get some text meant to be inserted but not as a link).
When opening a "search" provider, there is a focus loop issue slowing down the browser for a few seconds. Seems to be a focus trap issue.
We need to figure out a way to display the provider icon (from its URL) in the suggestions

juliusknorr · 2023-01-26T21:36:06Z

@julien-nc Pushed a few very minor fixes for the issues you found. The focus trap issue I could not reproduce so I assume it is a side effect of another app that you have enabled on your setup.

julien-nc · 2023-01-27T11:24:14Z

@juliushaertl Nice!
I've pushed a few adjustments:

make the provider icons smaller to make it consistent with those in RichContentEditable (which size was set to be consistent with the emojis)
increase suggestion list max-width to 400px because provider names can be long

Are you ok with those changes?

julien-nc · 2023-01-27T11:52:52Z

@julien-nc Pushed a few very minor fixes for the issues you found. The focus trap issue I could not reproduce so I assume it is a side effect of another app that you have enabled on your setup.

After frantically updating @nextcloud/vue in all my apps I realized I hadn't pull viewer for a long time...all good for the focus trap now.

julien-nc · 2023-01-27T12:42:54Z

"Open link picker" action is there. The icon might not be the best one.

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2023-01-30T13:36:19Z

Ready for review and good to get in from my side 👍

Let's file follow up tickets for:

Avoid to close text on esc key press
Cypress tests

mejo- · 2023-01-30T14:02:32Z

Very nice and works well ❤️

Unfortunately it brings back a bug that I had fixed in 6eb324f before: when opening the emoji picker, closing it with Esc and hitting enter, the emoji that was selected last still gets inserted. That's particularly annoying in languages like french, where single colons are often written.

The same bug exists with mentions (@), but there it's less annoying because single @ is not used as often.

julien-nc

Awesome. The Text operating system is on its way.

Can confirm the bug mentioned by @mejo- for all users, emojis and link providers.

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2023-01-30T16:05:29Z

Pushed a fix that applies for all autocomplete components now.

mejo-

Awesome. Works great and the latest fix by @juliushaertl also works ❤️

julien-nc

👍

julien-nc · 2023-01-30T16:26:26Z

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

julien-nc force-pushed the enh/link-picker branch from 6db89bf to 61ab927 Compare January 26, 2023 14:25

juliusknorr marked this pull request as ready for review January 26, 2023 21:36

juliusknorr requested review from julien-nc and mejo- January 26, 2023 21:36

juliusknorr added 3. to review enhancement New feature or request labels Jan 26, 2023

juliusknorr added this to the Nextcloud 26 milestone Jan 26, 2023

juliusknorr requested a review from max-nextcloud January 27, 2023 12:02

julien-nc force-pushed the enh/link-picker branch from ecffeda to 2517b7c Compare January 27, 2023 12:52

juliusknorr and others added 10 commits January 30, 2023 14:35

refactor(suggestion): Refactor existing suggestions to reuse logic

603096b

Signed-off-by: Julius Härtl <jus@bitgrid.net>

use vue-richtext helper functions to call the link picker

1a39895

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix(Suggestion): Close link picker tippy if selected

7c72748

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix(LinkPicker): Show icons

4a49052

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix(LinkPicker): Make sure that spaces after link paragraphs are ignored

9a05d97

Signed-off-by: Julius Härtl <jus@bitgrid.net>

tests(Mentions): Fix cypress selector for mentions test

26c2993

Signed-off-by: Julius Härtl <jus@bitgrid.net>

adjust link picker suggestion style

e02a2a1

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

allow larger suggestion list

a116634

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

add menu action to open link picker

6cda803

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

chore(dependencies): Bump @nextcloud/vue-richtext

932a2dc

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enh/link-picker branch from 2517b7c to 932a2dc Compare January 30, 2023 13:35

juliusknorr mentioned this pull request Jan 30, 2023

Editor frontend API #3615

Merged

21 tasks

julien-nc reviewed Jan 30, 2023

View reviewed changes

fix: Properly destroy tippy on escape

3ac47b9

Signed-off-by: Julius Härtl <jus@bitgrid.net>

mejo- approved these changes Jan 30, 2023

View reviewed changes

julien-nc self-requested a review January 30, 2023 16:25

julien-nc approved these changes Jan 30, 2023

View reviewed changes

Compile assets

82036c3

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

juliusknorr merged commit 84b65e1 into main Jan 30, 2023

delete-merged-branch Bot deleted the enh/link-picker branch January 30, 2023 16:56

This was referenced Feb 2, 2023

Use NC Search for link to calender, tasks, chat rooms, ... #1822

Closed

Slash commands #3761

Closed

blizzz mentioned this pull request Feb 9, 2023

25.0.4 RC1 nextcloud/server#36560

Merged

Navigation Menu

Uh oh!

Link picker - #3700

Link picker#3700
juliusknorr merged 12 commits into
mainfrom
enh/link-picker

juliusknorr commented Jan 26, 2023 •

edited

Loading

Uh oh!

cypress Bot commented Jan 26, 2023 •

edited

Loading

Uh oh!

julien-nc commented Jan 26, 2023 •

edited by juliusknorr

Loading

Uh oh!

juliusknorr commented Jan 26, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

juliusknorr commented Jan 30, 2023

Uh oh!

mejo- commented Jan 30, 2023

Uh oh!

julien-nc left a comment

Uh oh!

juliusknorr commented Jan 30, 2023

Uh oh!

mejo- left a comment

Uh oh!

julien-nc left a comment

Uh oh!

julien-nc commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

juliusknorr commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

Depends on

🏁 Checklist

Uh oh!

cypress Bot commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Passing run #8377 ↗︎

Uh oh!

julien-nc commented Jan 26, 2023 • edited by juliusknorr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusknorr commented Jan 26, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

julien-nc commented Jan 27, 2023

Uh oh!

juliusknorr commented Jan 30, 2023

Uh oh!

mejo- commented Jan 30, 2023

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

juliusknorr commented Jan 30, 2023

Uh oh!

mejo- left a comment

Choose a reason for hiding this comment

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

julien-nc commented Jan 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliusknorr commented Jan 26, 2023 •

edited

Loading

cypress Bot commented Jan 26, 2023 •

edited

Loading

julien-nc commented Jan 26, 2023 •

edited by juliusknorr

Loading