Skip to content

[stable22] Add light ⬇️ dowload icon - #1070

Merged
szaimen merged 1 commit into
stable22from
backport/1059/stable22
Nov 19, 2021
Merged

[stable22] Add light ⬇️ dowload icon#1070
szaimen merged 1 commit into
stable22from
backport/1059/stable22

Conversation

@backportbot-nextcloud

@backportbot-nextcloud backportbot-nextcloud Bot commented Nov 15, 2021 •
edited by szaimen
Loading

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #1059

For my own testing 
docker run -it \
-e SERVER_BRANCH=stable22 \
-e VIEWER_BRANCH=backport/1059/stable22 \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@backportbot-nextcloud backportbot-nextcloud Bot added this to the Nextcloud 22.2.3 milestone Nov 15, 2021
@szaimen szaimen self-assigned this Nov 15, 2021
@szaimen
szaimen force-pushed the backport/1059/stable22 branch from 7112381 to c4ccc3b Compare November 15, 2021 22:45
@szaimen

szaimen commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

/compile amend /

@szaimen szaimen added the 3. to review Waiting for reviews label Nov 15, 2021
@szaimen

szaimen commented Nov 15, 2021

Copy link
Copy Markdown
Contributor

Closing because I could not reproduce the initial issue on neither 22 nor 21

@szaimen szaimen closed this Nov 15, 2021
@szaimen
szaimen deleted the backport/1059/stable22 branch November 15, 2021 23:16
@szaimen szaimen removed this from the Nextcloud 22.2.3 milestone Nov 15, 2021
@beardhatcode

beardhatcode commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Odd @szaimen , did you:

  1. create a folder with some pictures in it
  2. create a read-only share link
  3. open te link
  4. open a picture

Because I initially had this problem on 22

@szaimen
szaimen restored the backport/1059/stable22 branch November 16, 2021 14:06
@szaimen

szaimen commented Nov 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the heads up, @beardhatcode!
No, I only tested with read-write shares. So this was problably my mistake...
Just testing with read-only shares...

@szaimen szaimen reopened this Nov 16, 2021
@szaimen

szaimen commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Could just reproduce it

@szaimen
szaimen force-pushed the backport/1059/stable22 branch from 32b889d to 1a50529 Compare November 16, 2021 14:16
@szaimen

szaimen commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

/compile amend /

@szaimen szaimen changed the title [stable22] Use modal-mask--dark selector to make icons light + add light ⬇️ dowload icon [stable22] Add light ⬇️ dowload icon Nov 16, 2021
@beardhatcode

beardhatcode commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

/compile amend /

@beardhatcode

beardhatcode commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

image

For some reason the images are not loading on cypress any more. I don't think this is related to this change. Might there be an issue with the docker?

@szaimen

szaimen commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud Bot added the backport-request Pending backport by the backport-bot label Nov 16, 2021
@szaimen

szaimen commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

For some reason the images are not loading on cypress any more. I don't think this is related to this change. Might there be an issue with the docker?

Honestly I don't know. Maybe @skjnldsv does?

@beardhatcode

beardhatcode commented Nov 17, 2021

Copy link
Copy Markdown
Contributor

/compile amend /

@beardhatcode

beardhatcode commented Nov 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think the failing test is caused by: b238271 creaded in #973 because of nextcloud/server#28079.

I will cherypink the disable HEIC commit.

@beardhatcode
beardhatcode force-pushed the backport/1059/stable22 branch from 1db21d4 to 849a481 Compare November 17, 2021 12:36
@beardhatcode

beardhatcode commented Nov 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

@skjnldsv or @szaimen All tests pass but something seems to be off with the runners. Could you manually merge this?

@beardhatcode

beardhatcode commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked the commit that fixes the GitHub actions

@beardhatcode
beardhatcode force-pushed the backport/1059/stable22 branch 2 times, most recently from 6f42ceb to 9eece2d Compare November 19, 2021 08:52
@beardhatcode

beardhatcode commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Rebased on #1071 (which should be merged first for a nicer commit history)

@beardhatcode
Add light ⬇️ download icon
71856dd 
Signed-off-by: Robbert Gurdeep Singh <git@beardhatcode.be>
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@beardhatcode
beardhatcode force-pushed the backport/1059/stable22 branch from 9eece2d to 71856dd Compare November 19, 2021 09:02
@szaimen

szaimen commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Thanks!

@szaimen
szaimen merged commit a0cb67a into stable22 Nov 19, 2021
@szaimen
szaimen deleted the backport/1059/stable22 branch November 19, 2021 09:16
@backportbot-nextcloud

backportbot-nextcloud Bot commented Nov 19, 2021

Copy link
Copy Markdown
Author

The backport to stable21 failed. Please do this backport manually.

@szaimen szaimen mentioned this pull request Nov 19, 2021
Merged
@beardhatcode
beardhatcode restored the backport/1059/stable22 branch November 19, 2021 11:34
@beardhatcode beardhatcode mentioned this pull request Nov 19, 2021
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2022
Merged
9 tasks
This was referenced Jan 20, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beardhatcode beardhatcode beardhatcode approved these changes
@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@szaimen szaimen

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@szaimen @beardhatcode