Update Ambassador Handbook - #336
Conversation
✅ Deploy Preview for nextflow-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@mribeirodantas There's a build error that needs to be addressed. Seems to be a missing dependency for the PDF. From the netlify logs:
12:45:37 PM: Running Sphinx v5.3.0
12:45:37 PM: Extension error:
12:45:37 PM: Could not import extension sphinx.builders.epub3 (exception: No module named 'imghdr')
12:45:38 PM: make: *** [Makefile:45: html] Error 2
12:45:38 PM: mv: cannot stat '_build/html/*': No such file or directory
12:45:39 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2
|
I reviewed the handbook, that looks good to me. Ok to merge once the failure is resolved. It does seem unrelated to the PR as such but unless we know exactly what's going on I'd rather not push anything through with errors. |
|
Googled it quickly - looks like this is a Python 13 thing. Fix should be to either upgrade Sphinx or pin Python 12 in the GitHub action. I propose the latter for now. You ok to add this to the PR @mribeirodantas? |
|
Oh wait. Is it Netlify only? Ok in that case I need to pin Python there. I'll see if I can do it on my phone. |
|
Ok, fixed in Netlify. Note that this is only used for deployment previews on PRs so the same issue could affect builds for production deployments in the future. We should therefore also pin Python 3.12 in GitHub actions. If anyone fancies throwing in a PR to do that separately so that I don't forget, it'd be much appreciated 🙏🏻 |
|
Not sure why the CI statuses aren't updating. The retried builds are fine. I guess pushing a new commit / rebasing and force pushing should solve that. |
4111403 to
936db20
Compare
|
Done. Opening the new PR with the 3.12 pin. Please 👍 review 😄 |
ewels
left a comment
There was a problem hiding this comment.
Haven't reviewed the PDF but others says it's fine 😅

No description provided.