Skip to content

Update Ambassador Handbook - #336

Merged
mribeirodantas merged 1 commit into
masterfrom
update_amb_handbook
Jan 3, 2025
Merged

Update Ambassador Handbook#336
mribeirodantas merged 1 commit into
masterfrom
update_amb_handbook

Conversation

@mribeirodantas

Copy link
Copy Markdown
Member

No description provided.

@netlify

netlify Bot commented Dec 25, 2024

Copy link
Copy Markdown

Deploy Preview for nextflow-staging ready!

Name Link
🔨 Latest commit 936db20
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-staging/deploys/6777d65ef1944000081e5923
😎 Deploy Preview https://deploy-preview-336--nextflow-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🟢 up 15 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kenibrewer kenibrewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mribeirodantas There's a build error that needs to be addressed. Seems to be a missing dependency for the PDF. From the netlify logs:

12:45:37 PM: Running Sphinx v5.3.0
12:45:37 PM: Extension error:
12:45:37 PM: Could not import extension sphinx.builders.epub3 (exception: No module named 'imghdr')
12:45:38 PM: make: *** [Makefile:45: html] Error 2
12:45:38 PM: mv: cannot stat '_build/html/*': No such file or directory
12:45:39 PM: Failed during stage 'building site': Build script returned non-zero exit code: 2 

@vdauwera

vdauwera commented Jan 2, 2025

Copy link
Copy Markdown
Collaborator

I reviewed the handbook, that looks good to me. Ok to merge once the failure is resolved. It does seem unrelated to the PR as such but unless we know exactly what's going on I'd rather not push anything through with errors.

@ewels

ewels commented Jan 3, 2025

Copy link
Copy Markdown
Member

Googled it quickly - looks like this is a Python 13 thing. Fix should be to either upgrade Sphinx or pin Python 12 in the GitHub action. I propose the latter for now. You ok to add this to the PR @mribeirodantas?

@ewels

ewels commented Jan 3, 2025

Copy link
Copy Markdown
Member

Oh wait. Is it Netlify only? Ok in that case I need to pin Python there. I'll see if I can do it on my phone.

@ewels

ewels commented Jan 3, 2025

Copy link
Copy Markdown
Member

Ok, fixed in Netlify. Note that this is only used for deployment previews on PRs so the same issue could affect builds for production deployments in the future. We should therefore also pin Python 3.12 in GitHub actions. If anyone fancies throwing in a PR to do that separately so that I don't forget, it'd be much appreciated 🙏🏻

@ewels

ewels commented Jan 3, 2025

Copy link
Copy Markdown
Member

Not sure why the CI statuses aren't updating. The retried builds are fine. I guess pushing a new commit / rebasing and force pushing should solve that.

@mribeirodantas

Copy link
Copy Markdown
Member Author

Done. Opening the new PR with the 3.12 pin. Please 👍 review 😄

@ewels ewels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the PDF but others says it's fine 😅

@mribeirodantas
mribeirodantas merged commit db2a69d into master Jan 3, 2025
@mribeirodantas
mribeirodantas deleted the update_amb_handbook branch January 3, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants