Skip to content

test: update freebayes test names and metadata - #12018

Merged
gbadedata merged 1 commit into
nf-core:masterfrom
gbadedata:fix/freebayes-test-names-ontologies
Jun 17, 2026
Merged

test: update freebayes test names and metadata#12018
gbadedata merged 1 commit into
nf-core:masterfrom
gbadedata:fix/freebayes-test-names-ontologies

Conversation

@gbadedata

Copy link
Copy Markdown
Contributor

PR checklist

Closes #7766

Description

Updates the affected freebayes nf-test names where human test data was labelled as sarscov2.

Also adds missing ontology entries to modules/nf-core/freebayes/meta.yml.

Changes

  • Renamed three freebayes nf-tests that use homo_sapiens test data.
  • Updated the matching nf-test snapshot keys.
  • Added missing EDAM ontology entries for freebayes inputs in meta.yml.
  • Updated the freebayes stub gzip syntax required by module lint.

Validation

  • nf-core modules lint freebayes
  • ./nf-test test modules/nf-core/freebayes/tests/main.nf.test

Both passed locally.

@gbadedata

Copy link
Copy Markdown
Contributor Author

@vagkaratzas
Local validation completed:

  • nf-core modules lint freebayes passed with 67 tests passed, 0 warnings, 0 failures.
  • ./nf-test test modules/nf-core/freebayes/tests/main.nf.test passed with 6 tests executed successfully.

The workflows are currently awaiting maintainer approval.

@vagkaratzas

Copy link
Copy Markdown
Contributor

Ask to join the slack nf-core organization on the nf-core slack github-invitations channel so your workflows can run without maintainer approval!

@vagkaratzas vagkaratzas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbadedata
gbadedata added this pull request to the merge queue Jun 17, 2026
Merged via the queue into nf-core:master with commit 6fd0d62 Jun 17, 2026
41 checks passed
@gbadedata
gbadedata deleted the fix/freebayes-test-names-ontologies branch June 17, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test names in freebayes test do not fit the used test data

2 participants