Skip to content

Implement smartcase search#366

Merged
noborus merged 2 commits into
noborus:masterfrom
resolritter:smartcase
Jun 2, 2023
Merged

Implement smartcase search#366
noborus merged 2 commits into
noborus:masterfrom
resolritter:smartcase

Conversation

@resolritter

Copy link
Copy Markdown
Contributor

close #365

@noborus

noborus commented Jun 1, 2023

Copy link
Copy Markdown
Owner

Thank you for the pull request.
It certainly seems better to have this.

@noborus

noborus commented Jun 2, 2023

Copy link
Copy Markdown
Owner

In this PR, smartcase is not displayed correctly in highlight display.
This is because FindAllString is done separately from searcher, and it is caused by the original code.
I would like to add FindAll and word methods to the searcher interface.

I'm thinking of adding this fix after merging.
thank you.

@noborus noborus merged commit fa64ef8 into noborus:master Jun 2, 2023
@resolritter resolritter deleted the smartcase branch June 2, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow for smartcase search

2 participants