Skip to content

repost TSC meeting minutes and recording post - #23

Merged
joyeecheung merged 2 commits into
nodejs:mainfrom
mhdawson:tsc-1
Dec 11, 2024
Merged

repost TSC meeting minutes and recording post#23
joyeecheung merged 2 commits into
nodejs:mainfrom
mhdawson:tsc-1

Conversation

@mhdawson

@mhdawson mhdawson commented Dec 11, 2024

Copy link
Copy Markdown
Member

No description provided.

@mhdawson
repost TSC meeting minutes and recording post
bcc09b5 
Signed-off-by: Michael Dawson <midawson@redhat.com>
richardlau
richardlau reviewed Dec 11, 2024
View reviewed changes
Comment thread records/tsc-24-12-11.json
mcollina
mcollina approved these changes Dec 11, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson
squash: move file to the correct directory
e3f4860 
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson

mhdawson commented Dec 11, 2024

Copy link
Copy Markdown
Member Author

Moved

@mhdawson

mhdawson commented Dec 11, 2024

Copy link
Copy Markdown
Member Author

Note sure about the validation failure, looks more like a missing environment config unless there is a typo that I don't see?

@joyeecheung

joyeecheung commented Dec 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

That's likely because it's run from a fork which has no access to the secrets, see #10 which is being worked on in #11

@joyeecheung
joyeecheung merged commit 76a96ff into nodejs:main Dec 11, 2024
@joyeecheung joyeecheung mentioned this pull request Dec 11, 2024
Merged
joyeecheung added a commit that referenced this pull request Dec 11, 2024
@joyeecheung @mhdawson
repost TSC meeting minutes and recording post (#23) (#24)
843520f 
* repost TSC meeting minutes and recording post



* squash: move file to the correct directory



---------

Signed-off-by: Michael Dawson <midawson@redhat.com>
Co-authored-by: Michael Dawson <mdawson@devrus.com>
This was referenced Dec 11, 2024
Closed
Merged
@joyeecheung

joyeecheung commented Dec 11, 2024

Copy link
Copy Markdown
Member

Looks like the fork repo has branch deletion settings, which is pending to resolve in #16 - in the mean time, I reopened #24 using a branch from this repo to get it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@mcollina mcollina mcollina approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mhdawson @joyeecheung @mcollina @richardlau @aduh95 @RafaelGSS