fix: validation of PRs from forks - #31
Merged
Merged
Conversation
aduh95
commented
Dec 13, 2024
aduh95
commented
Dec 13, 2024
bmuenzenmeyer
approved these changes
Dec 21, 2024
bmuenzenmeyer
left a comment
Contributor
There was a problem hiding this comment.
LGTM - coupled with the config change
joyeecheung
approved these changes
Dec 21, 2024
joyeecheung
left a comment
Member
There was a problem hiding this comment.
I feel that we can just skip running the action when there are any files outside of records/new, but this also LGTM
Member
|
Changed the permission 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By switching from
pull_requestevent topull_request_target, the workflow would have access to repo secrets. This should allow proper validation for PRs opened from a fork.This does come with more risks of leaking something, so I added a few protection mechanisms, and for extra piece of mind, I would recommend changing the setting below to the stricter "Require approval for all external contributors".