Sent test post to verify that the automation works - #5
Closed
joyeecheung wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Needs to get #6 in first or otherwise it doesn't setup corepack properly.. |
Member
Author
|
cc @nodejs/tsc |
anonrig
approved these changes
Dec 1, 2024
Member
Author
|
So the validate workflow is failing, and apparently the secrets are not passed into workflow runs triggered by PRs from forks. So I guess that means we should split the validation into two parts:
I'll close this one and open a new PR from a branch in this repo. Then open another PR to split the validation so that PRs sent from those who don't have write access to this repo can still get some local validation. |
This was referenced Dec 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funny enough I realized that the review guidelines didn't include this type of content, so I edited it a bit to add an exception 😅
Note the scripts aren't powerful enough to generate thumbnails yet (if you used links in bluesky before, you may have noticed that the thumbnails are uploaded from cards generated locally, which is also something that the automation needs to implement) but I think that's probably fine, just less visually pleasing but the links can be clickable all the same, it would look similar to https://bsky.app/profile/pixel-voyager.bsky.social/post/3lcbd6z3qh42j and we can work on cards later. Nobody expects the action to be perfect from the first iteration ;)