Added code name for Node 10#798
Closed
LaurentGoderre wants to merge 1 commit into
Closed
Conversation
Contributor
|
Is there a reference PR/Issue from the build repo that we can link this too? |
Member
Author
Contributor
|
Cool, thanks |
Contributor
|
Does the codename only take effect on the LTS date? |
Member
Author
Member
Author
|
@nodejs/lts can you answer @chorrell question about code names |
Contributor
|
I'm pretty sure the codename coincides with the LTS start date. Looking at the official schedule: https://github.com/nodejs/Release/blob/master/schedule.json v10 doesn't have it's assigned name yet. Maybe leave this open until Oct? |
Member
|
I submitted nodejs/Release#352 since the codename is used in a few other places |
Member
|
Code name only takes effect on the LTS release date |
Contributor
|
heads up: we landed this via #888 today 😄 |
Member
|
Thanks @knksmith57! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.