Skip to content

test: add hasIntl to failing test#13699

Closed
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:intl-test-fixes
Closed

test: add hasIntl to failing test#13699
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:intl-test-fixes

Conversation

@danbev

@danbev danbev commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@danbev
test: add hasIntl to failing test
82919d0 
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 15, 2017
@danbev

danbev commented Jun 15, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/8676/

@refack

refack commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

It is documented in anyway that WHATWG URL doesn't work without ICU?

@danbev

danbev commented Jun 15, 2017

Copy link
Copy Markdown
Contributor Author

It is documented in anyway that WHATWG URL doesn't work without ICU?

Sorry, I don't know if it is documented or not.

@refack

refack commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

It is documented in anyway that WHATWG URL doesn't work without ICU?

Sorry, I don't know if it is documented or not.

I'll go dig.

@TimothyGu

TimothyGu commented Jun 15, 2017

Copy link
Copy Markdown
Member

@refack

It is documented in anyway that WHATWG URL doesn't work without ICU?

Not that I am aware of. However, WHATWG URL does work without ICU, just not the Punycode encoding or decoding part.

@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Jun 15, 2017
cjihrig
cjihrig approved these changes Jun 15, 2017
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a question.

Comment thread test/parallel/test-icu-data-dir.js
'use strict';
require('../common');
const common = require('../common');
if (!(common.hasIntl && common.hasSmallICU)) {

@cjihrig cjihrig Jun 15, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is common.hasSmallICU a thing? I'm only finding process.binding('config').hasSmallICU with a quick search.

@danbev danbev Jun 15, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I was looking at an old commit and did not notice that that function does not exist or has been removed. Going to add it now. Thanks.

Trott
Trott previously requested changes Jun 15, 2017
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're adding a property to common, can you also add documentation for it in test/common/README.md?

@danbev

danbev commented Jun 16, 2017

Copy link
Copy Markdown
Contributor Author

If we're adding a property to common, can you also add documentation for it in test/common/README.md?

Ah sorry, forgot about that. I'll add that.

danbev added 2 commits June 16, 2017 07:35
@danbev
doc: add hasIntl to test/common/README.md
379d9cc 
Commit d7e4ae1
("test: add common.hasIntl") added common.hasIntl but I was not able to
find it in the README.md so this commit adds it.
@danbev
doc: add hasSmallICU to common/test/README.md
eb819b7
@Trott Trott dismissed their stale review June 16, 2017 05:45

docs added, dismissing review

danbev added a commit to danbev/node that referenced this pull request Jun 18, 2017
@danbev
doc: add hasIntl to test/common/README.md
282b1ed 
Commit d7e4ae1
("test: add common.hasIntl") added common.hasIntl but I was not able to
find it in the README.md so this commit adds it.

PR-URL: nodejs#13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danbev added a commit to danbev/node that referenced this pull request Jun 18, 2017
@danbev
test: add hasIntl to failing test
a8979a6 
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests

PR-URL: nodejs#13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

danbev commented Jun 18, 2017

Copy link
Copy Markdown
Contributor Author

Landed in a8979a6 and 282b1ed

@danbev danbev closed this Jun 18, 2017
addaleax pushed a commit that referenced this pull request Jun 18, 2017
@danbev @addaleax
doc: add hasIntl to test/common/README.md
807e8b7 
Commit d7e4ae1
("test: add common.hasIntl") added common.hasIntl but I was not able to
find it in the README.md so this commit adds it.

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 18, 2017
@danbev @addaleax
test: add hasIntl to failing test
5b4bbfa 
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
@danbev @addaleax
doc: add hasIntl to test/common/README.md
0114335 
Commit d7e4ae1
("test: add common.hasIntl") added common.hasIntl but I was not able to
find it in the README.md so this commit adds it.

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 20, 2017
@danbev @addaleax
test: add hasIntl to failing test
da84195 
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@danbev @addaleax
doc: add hasIntl to test/common/README.md
61714ac 
Commit d7e4ae1
("test: add common.hasIntl") added common.hasIntl but I was not able to
find it in the README.md so this commit adds it.

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@danbev @addaleax
test: add hasIntl to failing test
0d3b52e 
Currently when node is configured --without-intl the tests in this
commit fail. This commit adds checks for internationalization for these
tests

PR-URL: #13699
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
@TimothyGu TimothyGu added url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jun 26, 2017
@danbev danbev deleted the intl-test-fixes branch June 28, 2017 05:34
@MylesBorins

MylesBorins commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

should this be backported to v6.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott left review comments

+1 more reviewer

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n-api Issues and PRs related to the i18n implementation. test Issues and PRs related to the tests. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.