Skip to content

errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER#19808

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:errors-patch3
Closed

errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER#19808
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:errors-patch3

Conversation

@davidmarkclements

@davidmarkclements davidmarkclements commented Apr 4, 2018

Copy link
Copy Markdown
Member

changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Apr 4, 2018
@BridgeAR BridgeAR added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 4, 2018
errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER
9b24240 
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.
@BridgeAR

BridgeAR commented Apr 4, 2018

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/14055/

@BridgeAR BridgeAR requested a review from a team April 9, 2018 10:42
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
mcollina
mcollina approved these changes Apr 9, 2018
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina

mcollina commented Apr 9, 2018

Copy link
Copy Markdown
Member

Landed in add1c02

@mcollina mcollina closed this Apr 9, 2018
@mcollina mcollina removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
mcollina pushed a commit that referenced this pull request Apr 9, 2018
@mcollina
errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER
add1c02 
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.

PR-URL: #19808
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos

targos commented Apr 9, 2018

Copy link
Copy Markdown
Member

Since http2 is still experimental, I think this can be semver-patch?

@mcollina

mcollina commented Apr 9, 2018

Copy link
Copy Markdown
Member

@targos yes!

@BridgeAR BridgeAR removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 9, 2018
targos pushed a commit that referenced this pull request Apr 12, 2018
@targos
errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER
b74de4b 
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.

PR-URL: #19808
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@davidmarkclements @BridgeAR @mcollina @targos @jasnell @trivikr @nodejs-github-bot