module: rename anonymous functions

[ghost]

This is my first contribution 👋
#8913

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[lpinca]

Please see discussion in original issue #8913 (comment). I think consensus was to not name function on prototypes as the inferred name is actually better.

cc: @mcollina @Trott

[mcollina]

Unfortunately, none of these functions needs to be renamed. Everything is assigned to a prototype is generally ok.

[apapirovski]

@mcollina I don't think that's correct. The first function should still be renamed?

[mcollina]

Oh I just saw the others. yes, the first function should be renamed! Good spot!

[ghost]

Alright i'll keep that first function 👍

[trivikr]

@mcollina Should the names assigned to prototype functions (like from commit 25be2a3) in other files be removed?

[ghost]

I see this one too, https://github.com/nodejs/node/pull/20021/files#diff-0b93f5d72b0d34f5b972b661935344c3L196 in domain.js. That can be can be removed right?

[lpinca]

@dooven yes I think so.

[apapirovski]

@dooven There's one more of those lower down in the file EventEmitter.prototype.emit = function emit(...args) {

[ghost]

Thanks. Will update that

[trivikr]

CI: https://ci.nodejs.org/job/node-test-pull-request/14288/

[ghost]

Not sure how this job failed
https://ci.nodejs.org/job/node-test-commit-linux/17997/nodes=centos6-64-gcc6/

[Trott]

Re-running Linux CI, although it looks like it's been a while since there's been a green one so something might be up: https://ci.nodejs.org/job/node-test-commit-linux/18005/

[Trott]

OK, I think refack fixed the failing-to-build Linux host. Let's try again.

Linux CI: https://ci.nodejs.org/job/node-test-commit-linux/18009/

[Trott]

Last Linux re-run was green. This is good to land if there are no objections from any Collaborators after 72 hours has passed.

[mcollina]

LGTM

[trivikr]

Landed in ca41a30

Congratulations @dooven on your first commit to Node.js core! 🎉🎉🎉