Skip to content

lib: add diagnostics channel to process and worker#44045

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:add_diagnostics_channel_for_process_and_worker
Aug 30, 2022
Merged

lib: add diagnostics channel to process and worker#44045
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:add_diagnostics_channel_for_process_and_worker

Conversation

@theanarkh

@theanarkh theanarkh commented Jul 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add diagnostics channel to process and worker, so we can collect the process or worker info. Such as execPath, code, pid, threadId, performance info of worker threads and snapshot of worker threads, and so on.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Jul 29, 2022
@theanarkh theanarkh force-pushed the add_diagnostics_channel_for_process_and_worker branch from 24a078f to c6b068f Compare July 29, 2022 18:17
aduh95
aduh95 reviewed Jul 29, 2022
View reviewed changes
Comment thread doc/api/diagnostics_channel.md
Comment thread doc/api/diagnostics_channel.md
@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 29, 2022
@theanarkh theanarkh force-pushed the add_diagnostics_channel_for_process_and_worker branch from c6b068f to 62ce984 Compare July 29, 2022 19:25
@theanarkh theanarkh requested a review from aduh95 July 31, 2022 16:47
@aduh95

aduh95 commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

/cc @nodejs/workers

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46297/

@nodejs-github-bot

nodejs-github-bot commented Aug 29, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46307/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0633e9a into nodejs:main Aug 30, 2022
@nodejs-github-bot

nodejs-github-bot commented Aug 30, 2022

Copy link
Copy Markdown
Collaborator

Landed in 0633e9a

@RafaelGSS RafaelGSS mentioned this pull request Sep 5, 2022
Merged
@RafaelGSS RafaelGSS mentioned this pull request Sep 13, 2022
Merged
@juanarbol juanarbol mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. worker Issues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theanarkh @aduh95 @nodejs-github-bot @RafaelGSS @jasnell