module: only emit require(esm) warning under --trace-require-module#56194
Closed
joyeecheung wants to merge 2 commits into
Closed
module: only emit require(esm) warning under --trace-require-module#56194joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Collaborator
|
Review requested:
|
require(esm) is relatively stable now and the experimental warning has run its course - it's now more troublesome than useful. This patch changes it to no longer emit a warning unless `--trace-require-module` is explicitly used. The flag supports two modes: - `--trace-require-module=all`: emit warnings for all usages - `--trace-require-module=no-node-modules`: emit warnings for usages that do not come from a `node_modules` folder.
jasnell
reviewed
Dec 9, 2024
f64b4b4 to
4dde51d
Compare
jasnell
approved these changes
Dec 9, 2024
Collaborator
Collaborator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56194 +/- ##
==========================================
+ Coverage 87.99% 88.49% +0.50%
==========================================
Files 656 656
Lines 188959 189271 +312
Branches 35979 36346 +367
==========================================
+ Hits 166267 167496 +1229
+ Misses 15867 14973 -894
+ Partials 6825 6802 -23
|
aduh95
approved these changes
Dec 10, 2024
anonrig
approved these changes
Dec 10, 2024
Member
Author
|
I don't know if it's necessary since we aren't changing the stability index (I was thinking about changing it and then realized that it was already release candidate), but anyway cc @nodejs/tsc for awareness |
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
mcollina
approved these changes
Dec 10, 2024
mcollina
left a comment
Member
There was a problem hiding this comment.
lgtm
The warning actually broke one of my tests in v22 :).
GeoffreyBooth
approved these changes
Dec 10, 2024
2 tasks
Member
Author
|
backport in #56927 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require(esm) is relatively stable now and the experimental warning has run its course - it's now more troublesome than useful. This patch changes it to no longer emit a warning unless
--trace-require-moduleis explicitly used. The flag supports two modes:--trace-require-module=all: emit warnings for all usages--trace-require-module=no-node-modules: emit warnings for usages that do not come from anode_modulesfolder.Fixes: #55417
Refs: #55085 (comment)