Adding Google Analytics to doc pages.#6462
Closed
mikeal wants to merge 1 commit into
Closed
Conversation
Contributor
|
do we care that this will be executed when run locally? |
Member
|
hmm.. fwiw, I care that this would be executed when run locally. Couldn't this be injected only when the docs are on the website. -1 on this being here. |
Contributor
Author
|
Good point, pinging @nodejs/build to see if we can get this worked into that process. |
Member
|
SSI? Edit: would work like so: <!--# include file="tracking.html" --> |
Member
|
Given the -1's can we close this and defer the discussion over to the nodejs/nodejs.org repo? |
Member
|
@jasnell doesn't seem to be an open issue there. Want to create one? |
Member
|
We could use the sub module as well, but I'd like to do some performance measuring first seeing how we push 500mbit/sec+. |
Member
|
Done: nodejs/nodejs.org#709 |
Member
|
Lets close it and continue over there then. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the same analytics line to our documentation as we have on the rest of the website.