Skip to content

test: keep WPT backend checks alive #65320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Aug 18, 2026
+9 −1
Merged

test: keep WPT backend checks alive #65320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/parallel/test-common-wpt-backends.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,15 @@ async function collect(backend, throws) {
},
});

await handle.finished;
const watchdog = setTimeout(
common.mustNotCall(`The ${backend} WPT backend did not finish`),
common.platformTimeout(10_000),
);
try {
await handle.finished;
} finally {

@Hardanish-Singh Hardanish-Singh Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]: we should add a catch block here as well

clearTimeout(watchdog);
}
return events;
}

Expand Down
Loading