fs: handle recursive watch setup races

[panva]

Arm directory watchers before reading entries to close the setup window. Discard stale watcher state when paths disappear so recreated paths can be watched again.

On AIX, treat ENODEV as missing only when stat confirms the path is gone. Preserve root throwIfNoEntry behavior and other watch errors.

Fixes: #65697

[aduh95]

AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/64949/ 🟢

[codecov]

Codecov Report

❌ Patch coverage is 65.21739% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (f9ab994) to head (a075c13).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/recursive_watch.js	65.21%	21 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65699      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.02%     
==========================================
  Files         754      754              
  Lines      256395   256444      +49     
  Branches    48494    48516      +22     
==========================================
+ Hits       230947   230963      +16     
- Misses      16563    16582      +19     
- Partials     8885     8899      +14     

Files with missing lines	Coverage Δ
lib/internal/fs/recursive_watch.js	85.12% <65.21%> (-3.73%)	⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76822/

[lpinca]

RSLGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/76868/

[sxa]

@panva This is presumably blocked because it still has needs-ci on it but the github checks are complete. I do note that the last node-test-pull-request run didn't run to completion but I guess an earlier one did to make the github checks complete ok ... Should we just remove needs-ci?

[panva]

It is not blocked. It'll land with the first CQ after it ages.

node/doc/contributing/collaborator-guide.md

Lines 282 to 287 in 2befec5

	The `needs-ci` label identifies pull requests that require a full Jenkins CI
	run. It is a classification, not an indication that CI is still pending. Leave
	it in place after CI completes. Removing it does not waive the underlying CI
	requirement or make a pull request eligible to land without the required
	checks. Removing it also makes it harder for releasers to identify the scope of
	a change when working on a release proposal.

I do note that the last node-test-pull-request run didn't run to completion

It did. With known flakes. It's not red and it's not aborted. So it's good. Orange is acceptable.

git node land 65699                              
✔  Done loading data for nodejs/node/pull/65699
----------------------------------- PR info ------------------------------------
Title      fs: handle recursive watch setup races (#65699)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:fix-recursive-watch-aix-enodev -> nodejs:main
Labels     fs, author ready, needs-ci, commit-queue
Commits    2
 - fs: handle recursive watch setup races
 - fixup! fs: handle recursive watch setup races
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65699
Fixes: https://github.com/nodejs/node/issues/65697
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 01 Sep 2026 08:33:33 GMT
   ✔  Approvals: 2
   ✔  - Shelley Vohr (@codebytere): https://github.com/nodejs/node/pull/65699#pullrequestreview-5080561571
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65699#pullrequestreview-5082737185
   ✘  This PR needs to wait 15 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-09-02T03:52:29Z: https://ci.nodejs.org/job/node-test-pull-request/76868/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
? This PR is not ready to land, do you want to continue? (Y/n)