Skip to content

Split npm scripts and run them in parallel#2504

Merged
2 commits merged into
nodejs:masterfrom
XhmikosR:master-xmr-split-npm-scripts
Sep 8, 2019
Merged

Split npm scripts and run them in parallel#2504
2 commits merged into
nodejs:masterfrom
XhmikosR:master-xmr-split-npm-scripts

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

This is a first approach at addressing #2463.

Other changes:

  1. removed --fix from standard because on CI this didn't make the build fail. One can still do npm run test:lint:js -- --fix locally if they want to
  2. runs test:lint scripts in parallel

I still think we should move npm run build outside of tape and just run this before test. Build warnings aren't shown in tape

Fixes #2463

@XhmikosR XhmikosR changed the title Split npm scripts and run lint them in parallel Split npm scripts and run them in parallel Sep 5, 2019
@XhmikosR XhmikosR marked this pull request as ready for review September 6, 2019 05:59
@ghost ghost self-requested a review September 7, 2019 13:19
@ghost ghost requested review from Fishrock123 and Trott September 7, 2019 13:19
@Trott

Trott commented Sep 7, 2019

Copy link
Copy Markdown
Member

Seems fine to me.

@XhmikosR

XhmikosR commented Sep 7, 2019

Copy link
Copy Markdown
Contributor Author

@Trott how about moving build in scripts and not in tape? See #2442 (comment)

@Trott

Trott commented Sep 8, 2019

Copy link
Copy Markdown
Member

@Trott how about moving build in scripts and not in tape? See #2442 (comment)

👍

@XhmikosR

XhmikosR commented Sep 8, 2019

Copy link
Copy Markdown
Contributor Author

Cool, I'll make this change in another PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split npm test scripts

2 participants