Skip to content

Russian locale: remove untranslated files.#2527

Merged
1 commit merged into
nodejs:masterfrom
XhmikosR:master-xmr-rm-ru-english
Sep 8, 2019
Merged

Russian locale: remove untranslated files.#2527
1 commit merged into
nodejs:masterfrom
XhmikosR:master-xmr-rm-ru-english

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Sep 7, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no-one translating these files, no need to be kept here.

@Trott

Trott commented Sep 7, 2019

Copy link
Copy Markdown
Member

@nodejs/nodejs-ru

@Trott

Trott commented Sep 7, 2019

Copy link
Copy Markdown
Member

(I agree these can be removed if there is no translation going on. The ping was in case anyone wanted to translate one or more of these--in case they didn't realize there was lots of untranslated content.)

@XhmikosR

XhmikosR commented Sep 7, 2019

Copy link
Copy Markdown
Contributor Author

I'm just trying to clean up the locales. When a page has been translated, then it should be added, not before.

@XhmikosR

XhmikosR commented Sep 7, 2019

Copy link
Copy Markdown
Contributor Author

I see one ongoing translation in #2473. I can exclude the removal of this file assuming that PR will land.

@XhmikosR

XhmikosR commented Sep 8, 2019

Copy link
Copy Markdown
Contributor Author

So, how should we proceed with this?

@ghost

ghost commented Sep 8, 2019

Copy link
Copy Markdown

Until #2473 is merged

@XhmikosR

XhmikosR commented Sep 8, 2019

Copy link
Copy Markdown
Contributor Author

I don't follow? I can just skip this file from this PR, if #2473 is going to be merged.

Note that this removes obsolete/old files too.

@ghost

ghost commented Sep 8, 2019

Copy link
Copy Markdown

@XhmikosR , What I mean is you can revert ONLY this file 'locale/ru/docs/guides/simple-profiling.md' but just remove the others. But I still see your file is in the state of remove.
image

@ghost ghost merged commit dbffe19 into nodejs:master Sep 8, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-ru-english branch September 8, 2019 08:17
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants