Skip to content

Remove unused layouts and their CSS.#2624

Merged
nschonni merged 3 commits into
nodejs:masterfrom
XhmikosR:master-xmr-rm-unused-layouts
Oct 16, 2019
Merged

Remove unused layouts and their CSS.#2624
nschonni merged 3 commits into
nodejs:masterfrom
XhmikosR:master-xmr-rm-unused-layouts

Conversation

@XhmikosR

Copy link
Copy Markdown
Contributor
  • announcements.hbs
  • in-the-news.hbs

I left the blogAnnounce collection as is, although it probably is redundant too, so must be its feed

@XhmikosR

XhmikosR commented Sep 29, 2019

Copy link
Copy Markdown
Contributor Author

Actually now that I see site.json it seems the feed is also unused. Let me know how to proceed.

"feeds": [
{
"link": "feed/blog.xml",
"text": "Node.js Blog"
},
{
"link": "feed/releases.xml",
"text": "Node.js Blog: Releases"
},
{
"link": "feed/vulnerability.xml",
"text": "Node.js Blog: Vulnerability Reports"
}
],

@XhmikosR

XhmikosR commented Oct 1, 2019

Copy link
Copy Markdown
Contributor Author

@Trott should I also remove completely announcements?

@Aissaoui-Ahmed Aissaoui-Ahmed requested a review from Trott October 1, 2019 22:08
@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

@Trott should I also remove completely announcements?

I'm not sure. I don't know the ramifications. We can ping more widely for review or I can be educated.

@XhmikosR

XhmikosR commented Oct 1, 2019

Copy link
Copy Markdown
Contributor Author

Let's ask more people. I added the complete removal of announcements. Not sure if we should add any redirections or not.

@Trott

Trott commented Oct 2, 2019

Copy link
Copy Markdown
Member

@nodejs/website

@XhmikosR

XhmikosR commented Oct 14, 2019

Copy link
Copy Markdown
Contributor Author

@nodejs/build should we redirect the announcements index file or their feed? Note that this actually only removes the /announcements/index.html/ file and announcements.xml

Otherwise, I will split this patch so that we can merge the first one which is safe.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

Since I'm not getting any reviews, I dropped the second patch from this PR.

Now the patch just removes unused layouts and their CSS.

@XhmikosR XhmikosR marked this pull request as ready for review October 16, 2019 07:36

@rvagg rvagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.
I'm a little shocked that we have nobody showing up to review though? what happened to our website team and where is our shiny new website that we've had a whole team pouring over?

* announcements.hbs
* in-the-news.hbs
@XhmikosR XhmikosR changed the title Remove unused layouts. Remove unused layouts and their CSS. Oct 16, 2019
@alexandrtovmach

Copy link
Copy Markdown
Contributor

I think we haven't somebody who can give an answer about removed layouts, so let's merge PR and take a look on any issues that can be produced

@XhmikosR

Copy link
Copy Markdown
Contributor Author

This shouldn't affect anything. I moved the other patch to separate PRs.

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about removing the content (now in other PR), but these do look unreferenced anyway so 👍

@nschonni nschonni merged commit 682d82c into nodejs:master Oct 16, 2019
@bnb

bnb commented Oct 16, 2019

Copy link
Copy Markdown
Contributor

I'm a little shocked that we have nobody showing up to review though? what happened to our website team and where is our shiny new website that we've had a whole team pouring over?

@rvagg you can find that work in nodejs/nodejs.dev.

@rvagg

rvagg commented Oct 16, 2019

Copy link
Copy Markdown
Member

@bnb thanks, so when do we get to replace nodejs.org?

@bnb

bnb commented Oct 16, 2019

Copy link
Copy Markdown
Contributor

That's a great question. I'm not involved to the point to be able to assert an answer to it. Perhaps @amiller-gh could give some insight on, though I don't necessarily think this PR is the correct venue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants