Skip to content

feat: redesign the previous releases page - #7630

Merged
avivkeller merged 36 commits into
nodejs:mainfrom
araujogui:feat/redesign-releases
Apr 29, 2025
Merged

feat: redesign the previous releases page#7630
avivkeller merged 36 commits into
nodejs:mainfrom
araujogui:feat/redesign-releases

Conversation

@araujogui

@araujogui araujogui commented Apr 8, 2025

Copy link
Copy Markdown
Member

Description

Redesign the Previous Releases page

Related Issues

Fixes #7445

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel

vercel Bot commented Apr 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 28, 2025 5:02pm

Comment thread apps/site/components/Downloads/ReleaseModal/index.tsx Outdated
@avivkeller

Copy link
Copy Markdown
Member

looks good so far! Way to go! I've left one nitpick, but I know this is still a draft

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thing but there are a couple of things that need fine-tuning
V0 - v17 "Release Announcement" is throwing 404 because there are any post about that.

Comment thread apps/site/components/Downloads/DownloadReleasesTable/DetailsButton.tsx Outdated
Comment thread apps/site/components/Downloads/DownloadReleasesTable/index.tsx Outdated
Comment thread apps/site/components/Downloads/DownloadReleasesTable/index.tsx Outdated
Comment thread apps/site/components/Downloads/ReleaseModal/index.tsx Outdated
Comment thread apps/site/components/Downloads/ReleaseModal/index.tsx Outdated
Comment thread apps/site/components/Downloads/DownloadReleasesTable/index.tsx
@avivkeller

avivkeller commented Apr 17, 2025

Copy link
Copy Markdown
Member

IMO the code name feels too small, like it's part of the modal content, I feel it like it should be prominent (if present).

Maybe something like "Node.js 22 'Jod'" as a header?

(I know I initially said to prefix the version w/ "v", but looking at the release lines, they aren't prefixed like that anywhere else)


Also, TYSM for tackling this ♥️

@bjohansebas

Copy link
Copy Markdown
Member

Wow, overall I like it.

Btw, now there's a horizontal scroll on that page.
imagen

@araujogui

Copy link
Copy Markdown
Member Author

Wow, overall I like it.

Btw, now there's a horizontal scroll on that page. imagen

Yeah, I will create a smaller badge size. I'm also wondering if the N-API version is relevant for the users majority

@github-actions

github-actions Bot commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 86%
84.15% (494/587) 74.32% (165/222) 86.77% (105/121)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.961s ⏱️
@nodejs/website 156 0 💤 0 ❌ 0 🔥 6.536s ⏱️

Comment thread apps/site/components/Downloads/ReleaseOverview/index.tsx
Comment thread apps/site/components/Downloads/DownloadReleasesTable/index.tsx Outdated
Comment thread apps/site/components/Downloads/ReleaseOverview/index.tsx
Comment thread apps/site/components/Downloads/ReleaseOverview/index.tsx Outdated
Comment thread apps/site/components/Downloads/MinorReleasesTable/index.tsx

@bjohansebas bjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this change

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW awesome job done here !

@avivkeller

Copy link
Copy Markdown
Member

@araujogui

Copy link
Copy Markdown
Member Author

@araujogui Do you know the cause of https://github.com/nodejs/nodejs.org/actions/runs/14713449783/job/41291282023?pr=7630?

I have no idea, it works locally.

@araujogui

Copy link
Copy Markdown
Member Author

I only re-runned the workflow and it worked, weird

@avivkeller

Copy link
Copy Markdown
Member

#7630 (comment) #7630 (comment) are resolved, right?

If so, I think we can merge this!

@araujogui

Copy link
Copy Markdown
Member Author

#7630 (comment) #7630 (comment) are resolved, right?

If so, I think we can merge this!

It's resolved

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2025
@avivkeller
avivkeller enabled auto-merge April 29, 2025 12:25
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 29, 2025
@avivkeller
avivkeller added this pull request to the merge queue Apr 29, 2025
@avivkeller

Copy link
Copy Markdown
Member

Then, by the power invested in me, I now pronounce this PR merged!

Merged via the queue into nodejs:main with commit 0fec722 Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign the Previous Releases page

8 participants