feat(fetch): add Request{Init}.duplex and add WPTs - #1681
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
- Coverage 94.26% 94.25% -0.02%
==========================================
Files 53 53
Lines 4884 4887 +3
==========================================
+ Hits 4604 4606 +2
- Misses 280 281 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This appears to be causing a regression. We got a report that requests in SvelteKit are now failing: sveltejs/kit#7409. It seems that the |
|
can you open a new issue to track the regression, ideally with a repro? |
|
This is part of the spec now. When you have a ReadableStream body, the edit: as mentioned in issue, see this: whatwg/fetch@edf07e5#diff-b4827ee42aceaf9dc3e7216f72262d81c32217e9996fb70a657f259e3ac92604R6898-R6899 |
|
Thanks! We'll get SvelteKit updated. I wonder if this should have been a major release as it's a breaking change? |
|
Fetch in undici and node core are both considered experimental, so breaking changes should be expected. See https://github.com/nodejs/undici#undicifetchinput-init-promise and https://nodejs.org/dist/latest-v18.x/docs/api/all.html#all_globals_fetch It would likely be a good idea to pin undici's version and do manual updates to ensure nothing breaks between versions |
* feat(fetch): add `Request.duplex` and add WPTs * feat: add remaining applicable tests
* feat(fetch): add `Request.duplex` and add WPTs * feat: add remaining applicable tests
Request.duplexandRequestInit.duplextitleattributes in META tags.test(...)functions to fail due to the internal state being set. I could not tell you why this happened.Both tests that were added to the expected fails could likely be fixed, but I haven't looked into it.