fix(h2): handle GOAWAY for CONNECT streams - #5640
Merged
Merged
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v7.x #5640 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 112 112
Lines 36810 36811 +1
=======================================
+ Hits 34291 34293 +2
+ Misses 2519 2518 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Aug 6, 2026
Merged
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Backport of the fix for #5638 to
v7.x.Rationale
The
v7.xHTTP/2 implementation predates the stream-severing machinery onmain, but plain CONNECT streams have the analogous failure: unlike ordinary and WebSocket streams, they do not attach an error handler. GOAWAY teardown can therefore emit an unhandled stream error and terminate the process.Changes
Features
N/A
Bug Fixes
GOAWAY(lastStreamID=0).Breaking Changes and Deprecations
N/A
Status
Validation
npx borp -p "test/issue-5638.js"npx borp -p "test/http2-goaway.js" -p "test/http2-dispatcher.js"npx eslint lib/dispatcher/client-h2.js test/issue-5638.jsgit diff origin/v7.x...HEAD --check