Skip to content

test: skip HTTP/2 churn test on Node.js 25 on all platforms - #5790

Merged
mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:test/skip-http2-never-settles-on-node-25
Sep 13, 2026
Merged

mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:test/skip-http2-never-settles-on-node-25

Conversation

@kjsik11

@kjsik11 kjsik11 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This relates to...

Rationale

test/http2-request-never-settles.js sometimes fails in CI.
It is already skipped on Linux with Node.js 24, 25 but the same issue occurred on other platforms (macOS, Windows)

This issue will never be fixed on Node.js 25 because it reached EOL on 2026-06-01 (https://github.com/nodejs/Release/blob/main/schedule.json) so the test should be skipped with Node.js 25 on all platforms

Reproduced it on a clean windows-latest runner with Node.js 25 (6 parallel processes per iteration, up to 60 iterations)

Changes

  • test/http2-request-never-settles.js: Skipped test with Node.js 25 on all platforms

Status

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (b73952a) to head (1a6c0c7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5790      +/-   ##
==========================================
- Coverage   93.51%   93.51%   -0.01%     
==========================================
  Files         110      110              
  Lines       39359    39359              
==========================================
- Hits        36808    36807       -1     
- Misses       2551     2552       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@metcoder95
metcoder95 requested a review from mcollina September 10, 2026 08:56

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
mcollina merged commit 840b4e7 into nodejs:main Sep 13, 2026
38 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 14, 2026
@kjsik11
kjsik11 deleted the test/skip-http2-never-settles-on-node-25 branch September 17, 2026 01:04
This was referenced Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants