Skip to content

fix(h2): validate h2Options.maxConcurrentStreams itself - #5830

Merged
mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:fix/h2-options-max-concurrent-streams-validation
Sep 16, 2026
Merged

mcollina merged 1 commit into
nodejs:mainfrom
kjsik11:fix/h2-options-max-concurrent-streams-validation

Conversation

@kjsik11

@kjsik11 kjsik11 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

This relates to...

Regression from #5498. Supersedes the maxConcurrentStreams half of #5608.

Rationale

The maxConcurrentStreams was validated with the wrong option

Changes

  • lib/dispatcher/client.js: Validate maxConcurrentStreams correctly
  • test/http2-instantiation.js: Check the client-side h2Options (maxConcurrentStreams, connectionWindowSize, pingInterval) work when passed by themselves

Features

Bug Fixes

  • maxConcurrentStreams is now validated correctly

Breaking Changes and Deprecations

Tests

  • npm run lint
  • npm run test:h2:core (116/116)
  • npx borp --timeout 180000 -p "test/http2-instantiation.js" (4/4)

Status

@codecov-commenter

codecov-commenter commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.49%. Comparing base (485c85c) to head (17ed6fa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5830   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         110      110           
  Lines       39578    39578           
=======================================
  Hits        37003    37003           
  Misses       2575     2575           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina merged commit bfea020 into nodejs:main Sep 16, 2026
38 checks passed
@kjsik11
kjsik11 deleted the fix/h2-options-max-concurrent-streams-validation branch September 17, 2026 01:04
This was referenced Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants