Backport upgrade diagnostics lifecycle fixes to v6.x - #5833
Merged
Merged
Conversation
Successful CONNECT and protocol upgrades stop before Undici marks the request complete. Diagnostics subscribers retain request state, and streamed request-body listeners remain attached to the upgraded socket. Publish the existing response lifecycle around accepted upgrades. Preserve the early HTTP/2 CONNECT handoff in v6, and terminate diagnostics if the stream fails before its response. Refs: #5783 Signed-off-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
Completing upgrade requests suppresses late request errors, but v6 retains the abort callback as the transport cleanup owner after handoff. Returning early leaves upgraded sockets and HTTP/2 CONNECT streams open. Signed-off-by: Ruben Bridgewater <ruben.bridgewater@datadoghq.com>
BridgeAR
marked this pull request as ready for review
September 15, 2026 20:01
metcoder95
approved these changes
Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Backport of #5783 to
v6.x.Rationale
Successful CONNECT and protocol upgrades do not publish terminal request diagnostics. This retains subscriber state and request-body listeners for the upgraded socket lifetime.
Changes
Bug Fixes
Breaking Changes and Deprecations
N/A
Status