Conversation
cache.add()/addAll() fully read the response body (to avoid hanging, nodejs#5615/nodejs#5844), which disturbs the stored response's stream. A later cache.match()/matchAll() then tees that disturbed stream in cloneBody() and throws `ERR_INVALID_STATE: ReadableStream is locked`. Rebuild a fresh, regenerable body from the bytes read in processResponseConsumeBody, mirroring how Cache.put stores body.source. Fixes nodejs#5859 Signed-off-by: DevGnott <strelov.andre98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5859
Rationale
cache.add()/cache.addAll()fully read the response body while storingit (added in #5844 to avoid the hang from #5615). Reading disturbs the stored
response's stream, so a later
cache.match()/cache.matchAll()tees adisturbed stream in
cloneBody()and throwsTypeError [ERR_INVALID_STATE]: Invalid state: ReadableStream is locked.Cache.put()doesn't hit this because it stores the read bytes asbody.source. This applies the same idea to the add/addAll path.Changes
In
processResponseConsumeBody, rebuild a fresh, regenerable body from thebytes that were just read, so the stored response can be cloned later.
Features
N/A
Bug Fixes
cache.match()/cache.matchAll()no longer throwERR_INVALID_STATEafter
cache.add()/cache.addAll().Breaking Changes and Deprecations
N/A
Status