Revert "After install, rename nightly to the actual version string"#236
Merged
Conversation
This reverts commit 08ef798.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure how this was missed, but
after_install_packagecan't simply mv the installed version from 'nightly' to the versioned path. It causes any subsequent code which relies on$PREFIX_PATH(like fix_directory_permissions and any other registered hooks) to fail.Naive attempt to just modify
PREFIX_PATHas part of the after install hook was unsuccessful. It seemed to apply to fix_directory_permissions, but not any other registered after-install hooks.More work should be done to investigate options, but for now we need to at least allow nightlies to be installed as
nightly.fixes #235