deps: mark pyreadline3 as Windows-only - #253
Open
bjornars wants to merge 1 commit into
Open
Conversation
pyreadline3 is only imported when os.name == 'nt' (novem/cli/__init__.py), as a stand-in for the stdlib readline module which is unavailable on Windows. Add an os_name == 'nt' environment marker so it is no longer installed on Linux/macOS, where it is never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyreadline3is only imported whenos.name == "nt"(seenovem/cli/__init__.py), where it stands in for the stdlibreadlinemodule that isn't available on Windows. On Linux/macOS the stdlibreadlineis used andpyreadline3is never touched.This adds an
os_name == 'nt'environment marker to the dependency so it is no longer installed on non-Windows platforms.pyproject.toml:"pyreadline3>=3.5.4 ; os_name == 'nt'"uv.lock: regenerated;uv lock --checkpassesNo behavior change — the import was already guarded by the
os.namecheck.