Fix navigation inside tabs with a tableview replacing all query param…#1218
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to stop URL flicker / infinite navigation loops when switching tabs that contain a TableView, by preventing competing navigate(...) calls from repeatedly overwriting each other’s query parameters (Issue #1199).
Changes:
- Updates
useSyncTabSearchto decide whether to navigate based on the currenttabquery param value (instead of comparing the wholelocation.searchstring). - Updates
TableView’s table-state URL builder to preserve existing query params when adding/updating thetableStateparam.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/hooks/useSyncTabSearch.ts | Changes tab-sync logic to check only the tab param before navigating. |
| frontend/src/components/TableView/TableView.tsx | Preserves existing query params when adding tableState to generated URLs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s in url
See #1199 . The problem was that when switching to any tab with a TableView inside,
useSyncTabSearchreplaced thetableStatequery param with itstabparam. Now whenever a tab is changed, all query params are cleared, and thetableStatequery param is added to the URL afterwards.