Skip to content

feat: add --iwr alias for --include-workspace-root#4864

Merged
wraithgar merged 1 commit into
latestfrom
fritzy/iwr
May 9, 2022
Merged

feat: add --iwr alias for --include-workspace-root#4864
wraithgar merged 1 commit into
latestfrom
fritzy/iwr

Conversation

@fritzy

@fritzy fritzy commented May 5, 2022

Copy link
Copy Markdown

Added a shorthand form of --include-workspace-root as --iwr.

@fritzy fritzy requested a review from a team as a code owner May 5, 2022 17:28
@npm-robot

npm-robot commented May 5, 2022

Copy link
Copy Markdown
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 114.953 ±96.14 28.289 ±0.46 15.733 ±0.02 17.753 ±0.65 2.367 ±0.03 2.409 ±0.04 1.919 ±0.05 9.983 ±0.01 2.035 ±0.30 2.783 ±0.12
#4864 56.069 ±5.46 28.551 ±0.36 26.128 ±14.03 17.942 ±0.64 2.542 ±0.00 2.484 ±0.08 1.992 ±0.02 10.098 ±0.05 1.918 ±0.07 3.070 ±0.42
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.880 ±2.25 22.002 ±0.30 11.758 ±0.02 12.737 ±0.14 2.357 ±0.00 2.363 ±0.00 2.075 ±0.03 7.631 ±0.10 1.954 ±0.01 2.648 ±0.00
#4864 34.338 ±0.70 21.444 ±0.20 11.437 ±0.19 12.645 ±0.01 2.347 ±0.01 2.335 ±0.00 2.052 ±0.03 7.659 ±0.13 1.933 ±0.02 2.632 ±0.03

@nlf nlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could maybe use docs somewhere, but the change looks good

@missionzero316 missionzero316 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tap-snapshots/test/lib/utils/config/index.js.test.cj

@missionzero316 missionzero316 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tap-snapshots/test/lib/utils/config/index.js.test.cjslib/utils/config/index.jsdocs/content/using-npm/config.md

@mesqueeb

Copy link
Copy Markdown

@fritzy @nlf can you add this to the docs? 🙇🏻 and is it --iwr or -iwr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants