You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The AccentColorPicker.vue component has been modified to enhance how it handles the prehydration of selected accent colours. When the server-selected colour ID is found, the code now both sets input.checked to true and explicitly adds the checked attribute using setAttribute(). Additionally, the implementation now explicitly deselects the default "clear" option by unchecking it and removing its checked attribute when a non-default accent colour is loaded. These changes ensure consistent handling of input state between property values and DOM attributes.
The pull request description directly addresses the changeset purpose: fixing a hydration mismatch in the accent color picker component.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/checked-picker
No actionable comments were generated in the recent review. 🎉
🧹 Recent nitpick comments
app/components/Settings/AccentColorPicker.vue (1)
10-10: Consider using CSS.escape() for the selector value.
If id ever contains CSS selector metacharacters (e.g., ", ], \), the query selector would break or behave unexpectedly. While the risk is low since id comes from controlled localStorage data, escaping is a more robust pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this addresses another hydration mismatch