ci: improve workflows - #3147
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughGitHub Actions workflows now apply repository guards, use updated runners, parallelise Codecov uploads, fetch full canary history, and pin the Lunaria action to a release commit. ChangesCI workflow updates
Suggested reviewers: Priority: ⬇️ Low 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/welcome-open.yml:
- Line 18: Update the greeting job’s runs-on setting from ubuntu-slim to a full
Ubuntu runner such as ubuntu-latest so the Docker-based
zephyrproject-rtos/action-first-interaction step can execute successfully.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f22f5430-48a1-4ba2-9ad8-51b06f62b94a
📒 Files selected for processing (7)
.github/workflows/chromatic.yml.github/workflows/ci.yml.github/workflows/deploy-canary.yml.github/workflows/lunaria.yml.github/workflows/mirror-tangled.yml.github/workflows/stale.yml.github/workflows/welcome-open.yml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
serhalp
left a comment
There was a problem hiding this comment.
Makes sense to me, thank you!
|
Changes sound good to me, just wanna try and follow up on why the changes to the runners were originally made - will get back to you soon hopefully 🙏 |
trueberryless
left a comment
There was a problem hiding this comment.
Thanks for the PR, @luc122c
Everything looks good to me, I just adapted the Zizmor ignore rule to point to the updated line. I'll wait for @ghostdevv to approve and merge 🚀
🔗 Linked issue
Related: #2971
🧭 Context
A few improvements to the GitHub Actions workflows, following the same pass I've been doing across other repos.
📚 Description
ubuntu-slimrunnerUse
ubuntu-slimfor the lightweight jobs —ci.yml(i18n),stale.yml,welcome-open.yml,mirror-tangled.yml, anddeploy-canary.yml. The runner readme provides more info about the tools and the GA blog post gives some potential use cases.The heavier jobs (full dependency install + local build) stay on
ubuntu-24.04-arm:lint(the oxc-parser-based linter needs more than the 5 GB RAM onubuntu-slim),types,unit,test,browser,knip,autofix, andzizmor(which runs as a Docker-container action and needs a Docker-capable runner).a11ystays onubuntu-latestfor the documented Lighthouse reason.deploy-canaryandmirror-tangledonly install a CLI / do git ops, so the build that matters for canary happens remotely on Vercel.parallelkeywordRun the two independent Codecov uploads (test results + coverage) in parallel in the
unitandtestjobs, using the new nativeparallelkeyword.Restrict preview/comment workflows to the main repo
Gate
chromatic.ymlandlunaria.ymlbehindif: github.repository == 'npmx-dev/npmx.dev'so fork PRs don't consume Chromatic builds or triggerpull_request_targetcomments in the org repo. The other release/deploy/mirror/comment workflows already had this guard.