Skip to content

ci: improve workflows - #3147

Merged
trueberryless merged 11 commits into
npmx-dev:mainfrom
luc122c:feat/improve-workflows
Sep 20, 2026
Merged

trueberryless merged 11 commits into
npmx-dev:mainfrom
luc122c:feat/improve-workflows

Conversation

@luc122c

@luc122c luc122c commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Related: #2971

🧭 Context

A few improvements to the GitHub Actions workflows, following the same pass I've been doing across other repos.

📚 Description

ubuntu-slim runner

Use ubuntu-slim for the lightweight jobs — ci.yml (i18n), stale.yml, welcome-open.yml, mirror-tangled.yml, and deploy-canary.yml. The runner readme provides more info about the tools and the GA blog post gives some potential use cases.

The heavier jobs (full dependency install + local build) stay on ubuntu-24.04-arm: lint (the oxc-parser-based linter needs more than the 5 GB RAM on ubuntu-slim), types, unit, test, browser, knip, autofix, and zizmor (which runs as a Docker-container action and needs a Docker-capable runner). a11y stays on ubuntu-latest for the documented Lighthouse reason. deploy-canary and mirror-tangled only install a CLI / do git ops, so the build that matters for canary happens remotely on Vercel.

parallel keyword

Run the two independent Codecov uploads (test results + coverage) in parallel in the unit and test jobs, using the new native parallel keyword.

Restrict preview/comment workflows to the main repo

Gate chromatic.yml and lunaria.yml behind if: github.repository == 'npmx-dev/npmx.dev' so fork PRs don't consume Chromatic builds or trigger pull_request_target comments in the org repo. The other release/deploy/mirror/comment workflows already had this guard.

@vercel

vercel Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Sep 19, 2026 9:32pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Sep 19, 2026 9:32pm UTC
npmx-lunaria Ignored Ignored Sep 19, 2026 9:32pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3ae14016-4f6f-4677-8895-f82dbc956a3a

📥 Commits

Reviewing files that changed from the base of the PR and between c7448d4 and a654f68.

📒 Files selected for processing (2)
  • .github/workflows/lunaria.yml
  • .github/zizmor.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/lunaria.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated automation jobs to use a streamlined runner configuration.
    • Restricted selected repository-specific workflows to run only in the intended repository.
    • Separated unit-test and component-test reporting while preserving test and coverage uploads.
    • Pinned the documentation workflow to a stable release.
    • Updated canary deployment checkout history handling.
    • Updated workflow validation references.
    • Preserved existing deployment, mirroring, stale-management and localisation workflow behaviour.

Walkthrough

GitHub Actions workflows now apply repository guards, use updated runners, parallelise Codecov uploads, fetch full canary history, and pin the Lunaria action to a release commit.

Changes

CI workflow updates

Layer / File(s) Summary
Parallelise test reporting
.github/workflows/ci.yml
Unit-test and component-test Codecov uploads now use separate parallel test-result and coverage steps.
Update workflow execution rules and runners
.github/workflows/*.yml
Selected jobs now use ubuntu-slim. Chromatic and Lunaria jobs require the npmx-dev/npmx.dev repository.
Update checkout history and action pinning
.github/workflows/deploy-canary.yml, .github/workflows/lunaria.yml, .github/zizmor.yml
The canary checkout fetches full history. The Lunaria action uses the v0.2.0 release commit. The zizmor reference targets the updated line.

Suggested reviewers: trueberryless

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies improvements to CI workflows and matches the main changes, including runner updates, parallel Codecov uploads, and repository gating.
Description check ✅ Passed The description is directly related to the workflow changes and explains the runner selection, parallel uploads, repository restrictions, and linked issue.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/welcome-open.yml:
- Line 18: Update the greeting job’s runs-on setting from ubuntu-slim to a full
Ubuntu runner such as ubuntu-latest so the Docker-based
zephyrproject-rtos/action-first-interaction step can execute successfully.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f22f5430-48a1-4ba2-9ad8-51b06f62b94a

📥 Commits

Reviewing files that changed from the base of the PR and between 4b40e42 and c96614d.

📒 Files selected for processing (7)
  • .github/workflows/chromatic.yml
  • .github/workflows/ci.yml
  • .github/workflows/deploy-canary.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/mirror-tangled.yml
  • .github/workflows/stale.yml
  • .github/workflows/welcome-open.yml

Comment thread .github/workflows/welcome-open.yml Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Comment thread .github/workflows/mirror-tangled.yml

@serhalp serhalp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@ghostdevv

Copy link
Copy Markdown
Member

Changes sound good to me, just wanna try and follow up on why the changes to the runners were originally made - will get back to you soon hopefully 🙏

@ghostdevv ghostdevv removed the needs discussion An idea that needs more discussion to understand the scope and impact. label Aug 18, 2026
@github-actions github-actions Bot added the stale This has become stale and may be closed soon label Sep 18, 2026
Comment thread .github/workflows/lunaria.yml Outdated
Comment thread .github/workflows/lunaria.yml

@trueberryless trueberryless left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @luc122c

Everything looks good to me, I just adapted the Zizmor ignore rule to point to the updated line. I'll wait for @ghostdevv to approve and merge 🚀

@github-actions github-actions Bot removed the stale This has become stale and may be closed soon label Sep 20, 2026
@trueberryless
trueberryless added this pull request to the merge queue Sep 20, 2026
Merged via the queue into npmx-dev:main with commit deed0d2 Sep 20, 2026
24 checks passed

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – npmx.dev — a654f681 Deployed Sep 19, 2026 by vercel[bot]
Preview – docs.npmx.dev — a777817f Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants