Skip to content

chore: stabilize Lunaria - #3268

Merged
danielroe merged 2 commits into
npmx-dev:mainfrom
trueberryless:chore/lunaria-v0.2
Sep 19, 2026
Merged

danielroe merged 2 commits into
npmx-dev:mainfrom
trueberryless:chore/lunaria-v0.2

Conversation

@trueberryless

@trueberryless trueberryless commented Sep 19, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

This PR updates Lunaria to a stable version (released earlier this week) and also removes some dead code and fixes our canary translation status issue.

📚 Description

This PR updates Lunaria to 0.2. We were already targeting this version via pre-releases, so no code changes are necessary.

I also removed the HTML output from Lunaria, since we just use the status.json output for our custom translation tracker under https://i18n.npmx.dev/ (which redirects to https://main.npmx.dev/translation-status).

I then noticed that https://main.npmx.dev/translation-status is not loading any status and figured that the reason is very likely that we use fetch-depth: 2 in the deploy-canary.yml (see #2860). However, Lunaria always needs fetch-depth: 0 to get the full history (no shallow clone). Let's see if this works 🤞

@vercel

vercel Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Sep 19, 2026 8:07pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Sep 19, 2026 8:07pm UTC
npmx-lunaria Ignored Ignored Sep 19, 2026 8:07pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: npmx-dev/npmx.dev/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 780ac1e6-ad7c-4e7c-a682-121ede639800

📥 Commits

Reviewing files that changed from the base of the PR and between 59cf147 and 50ea330.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • .github/workflows/autofix.yml
  • .github/workflows/deploy-canary.yml
  • lunaria/components.ts
  • lunaria/lunaria.ts
  • lunaria/styles.ts
  • package.json
💤 Files with no reviewable changes (2)
  • lunaria/styles.ts
  • lunaria/components.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Changes

    • Translation-status generation now produces a machine-readable status file only; the HTML dashboard and its styling have been removed.
    • Existing translation-status data generation remains available through the generated status output.
  • Deployment and CI

    • Canary deployments and automated fixes now use the complete repository history.
  • Maintenance

    • Updated the project’s core package to the stable 0.2.0 release.

Walkthrough

Lunaria no longer generates the HTML dashboard or its styles. It writes only dist/lunaria/status.json. The core dependency now uses version 0.2.0, and both workflows perform full Git checkouts.

Changes

Lunaria output and release configuration

Layer / File(s) Summary
Remove HTML dashboard generation
lunaria/components.ts, lunaria/styles.ts, lunaria/lunaria.ts
The HTML renderer, CSS templates, import, HTML output, and related log entry were removed. Lunaria continues to write dist/lunaria/status.json.
Update release configuration
.github/workflows/deploy-canary.yml, .github/workflows/autofix.yml, package.json
Both workflow checkouts now fetch the complete repository history. @lunariajs/core now resolves to published version 0.2.0.

Priority: ➖ Normal

Severity of issue fixed: Medium

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed For #2785, lunaria/lunaria.ts now generates dist/lunaria/status.json, and the HTML output no longer replaces this status output. package.json uses stable @lunariajs/core version 0.2.0. `.git…
Out of Scope Changes check ✅ Passed The deletion of lunaria/components.ts and lunaria/styles.ts removes unused HTML output that is replaced by status-only generation. The stable Lunaria dependency supports the same migration. The `f…
Title check ✅ Passed The title is concise and directly relates to the main change: stabilising the Lunaria integration.
Description check ✅ Passed The description clearly explains the Lunaria upgrade, removal of unused HTML output, and Git history fix for translation status generation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@socket-security

socket-security Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​lunariajs/​core@​0.2.0791009287100

View full report

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown

📊 Dependency Size Changes

Warning

This PR adds 5.4 MB of new dependencies, which exceeds the threshold of 200 kB.

📦 Package 📏 Size
zod@4.6.5 6.1 MB
jiti@2.3.3 -2.1 MB
yaml@2.9.1 686.3 kB
iconv-lite@0.6.3 348.5 kB
@lunariajs/core@0.2.0 174.4 kB
neotraverse@0.6.18 → neotraverse@1.0.1 98.2 kB
gettext-parser@9.1.1 56.9 kB
encoding@0.1.13 7.1 kB
@lunariajs/core@https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@904b935 Unknown

Total size change: 5.4 MB

@trueberryless

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@danielroe
danielroe added this pull request to the merge queue Sep 19, 2026
@danielroe danielroe changed the title chore: stabalize Lunaria chore: stabilize Lunaria Sep 19, 2026
Merged via the queue into npmx-dev:main with commit e8296eb Sep 19, 2026
26 checks passed

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – npmx.dev — 50ea3300 Deployed Sep 19, 2026 by vercel[bot]
Preview – docs.npmx.dev — dc3ec41a Deployed Sep 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translation Status Page doesn’t load

2 participants